Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(category_theory/monoidal): skeleton of a monoidal category is a monoid #6444

Closed
wants to merge 8 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Feb 26, 2021


cc: @kbuzzard - this is the monoid on the isomorphism classes of a monoidal category you were talking about, and I've put a todo for the commutative monoid when the category is braided

@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Feb 26, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@b-mehta
Copy link
Collaborator Author

b-mehta commented Feb 27, 2021

@bryangingechen Is it expected that the tick-box in the original message isn't ticked but the dependent PRs are merged?

@bryangingechen
Copy link
Collaborator

@bryangingechen Is it expected that the tick-box in the original message isn't ticked but the dependent PRs are merged?

That's a bit weird. Looking at the list of GitHub actions run results, it seems that the "cross of linked issues" task didn't run for #6442, and I don't have any clue why.

In any case it's just a "cosmetic" bug. As you can tell, the "dependent issues bot" was still able to figure out that all the dependencies were merged. I'll check the box in the PR comment now.

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Feb 27, 2021
@robertylewis robertylewis added the awaiting-review The author would like community review of the PR label Feb 28, 2021
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 28, 2021
bors bot pushed a commit that referenced this pull request Feb 28, 2021
@bors
Copy link

bors bot commented Mar 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/monoidal): skeleton of a monoidal category is a monoid [Merged by Bors] - feat(category_theory/monoidal): skeleton of a monoidal category is a monoid Mar 1, 2021
@bors bors bot closed this Mar 1, 2021
@bors bors bot deleted the monoidal-skeleton branch March 1, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants