Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/special_functions/pow): smoothness of complex.cpow #6447

Closed
wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 26, 2021

  • x ^ y is smooth in both variables at (x, y), if 0 < re x or
    im x ≠ 0;
  • x ^ y is smooth in y if x ≠ 0 or y ≠ 0.

I'm not sure that we should use 0 < re x ∨ im x ≠ 0 as an assumption
or switch to ¬(re x ≤ 0 ∧ im x = 0). Same question about
x ≠ 0 ∨ y ≠ 0 vs ¬(x = 0 ∧ y = 0).

* `x ^ y` is smooth in both variables at `(x, y)`, if `0 < re x` or
  `im x ≠ 0`;
* `x ^ y` is smooth in `y` if `x ≠ 0` or `y ≠ 0`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Feb 26, 2021
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the assumptions are fine as they are, because it means you only need to check one condition.

src/analysis/special_functions/trigonometric.lean Outdated Show resolved Hide resolved
src/analysis/special_functions/pow.lean Outdated Show resolved Hide resolved
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Feb 28, 2021
bors bot pushed a commit that referenced this pull request Feb 28, 2021
…6447)

* `x ^ y` is smooth in both variables at `(x, y)`, if `0 < re x` or
  `im x ≠ 0`;
* `x ^ y` is smooth in `y` if `x ≠ 0` or `y ≠ 0`.
@bors
Copy link

bors bot commented Feb 28, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions/pow): smoothness of complex.cpow [Merged by Bors] - feat(analysis/special_functions/pow): smoothness of complex.cpow Feb 28, 2021
@bors bors bot closed this Feb 28, 2021
@bors bors bot deleted the cpow-tcd branch February 28, 2021 11:53
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…6447)

* `x ^ y` is smooth in both variables at `(x, y)`, if `0 < re x` or
  `im x ≠ 0`;
* `x ^ y` is smooth in `y` if `x ≠ 0` or `y ≠ 0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants