Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a linter for incorrectly used decidable arguments #6485

Closed
wants to merge 5 commits into from
Closed

Add a linter for incorrectly used decidable arguments #6485

wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser added the WIP Work in progress label Feb 28, 2021
@eric-wieser eric-wieser mentioned this pull request Mar 1, 2021
Closed
@eric-wieser eric-wieser closed this Mar 1, 2021
@eric-wieser eric-wieser reopened this Mar 1, 2021
@eric-wieser
Copy link
Member Author

CI wasn't running for some reason

bors bot pushed a commit that referenced this pull request Mar 2, 2021
@eric-wieser
chore(logic/function/basic): remove classical decidable instance from…
5361162 
… a lemma statement (#6488)

Found using #6485

This means that this lemma can be use in reverse against any `ite`, not just one that uses `classical.decidable`.
bors bot pushed a commit that referenced this pull request Mar 2, 2021
@eric-wieser
chore(logic/function/basic): remove classical decidable instance from…
c5e1ad0 
… a lemma statement (#6488)

Found using #6485

This means that this lemma can be use in reverse against any `ite`, not just one that uses `classical.decidable`.
bors bot pushed a commit that referenced this pull request Apr 7, 2021
@eric-wieser
chore(logic/function/basic): remove classical decidable instance from…
97832da 
… a lemma statement (#6488)

Found using #6485

This means that this lemma can be use in reverse against any `ite`, not just one that uses `classical.decidable`.
@eric-wieser eric-wieser mentioned this pull request Apr 21, 2021
Closed
bors bot pushed a commit that referenced this pull request Apr 21, 2021
@eric-wieser
fix(data/{finsupp,polynomial,mv_polynomial}/basic): add missing decid…
f2984d5 
…able arguments (#7309)

Lemmas with an `ite` in their conclusion should not use `classical.dec` or similar, instead inferring an appropriate decidability instance from their context. This eliminates a handful of converts elsewhere.

The linter in #6485 should eventually find these automatically.
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 13, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jun 24, 2021
@YaelDillies
Copy link
Collaborator

Given that this is meta code, I'm afraid it will have to be redone after the port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maybe-later WIP Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eric-wieser @YaelDillies