Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/equiv): add missing simp lemmas about mk #6505

Closed
wants to merge 7 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Mar 2, 2021

This adds missing mk_coe lemmas, and new symm_mk, symm_bijective, and mk_coe' lemmas.


@[simp, to_additive] lemma mk_coe (e : M ≃* N) (e' h₁ h₂ h₃) :
(⟨e, e', h₁, h₂, h₃⟩ : M ≃* N) = e := ext $ λ _, rfl

@[simp] lemma mk_coe' (e : M ≃* N) (f h₁ h₂ h₃) :
Copy link
Member

@urkud urkud Mar 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to_additive? Here and in other lemmas in this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM
bors d+

@bors
Copy link

bors bot commented Mar 2, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud urkud added the delegated The PR author may merge after reviewing final suggestions. label Mar 2, 2021
@eric-wieser
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Mar 3, 2021
This adds missing `mk_coe` lemmas, and new `symm_mk`, `symm_bijective`, and `mk_coe'` lemmas.
@bors
Copy link

bors bot commented Mar 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/equiv): add missing simp lemmas about mk [Merged by Bors] - chore(data/equiv): add missing simp lemmas about mk Mar 3, 2021
@bors bors bot closed this Mar 3, 2021
@bors bors bot deleted the eric-wieser/equiv-mk_coe branch March 3, 2021 10:36
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
This adds missing `mk_coe` lemmas, and new `symm_mk`, `symm_bijective`, and `mk_coe'` lemmas.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants