Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/ordered_monoid): linear_ordered_add_comm_monoid(_with_top) #6520

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat(algebra/ordered_monoid): linear_ordered_add_comm_monoid(_with_top) #6520

wants to merge 18 commits into from

Conversation

awainverse
Copy link
Collaborator

@awainverse awainverse commented Mar 3, 2021 •
edited by github-actions bot

Separates out classes for linear_ordered_(add_)comm_monoid
Creates linear_ordered_add_comm_monoid_with_top, an additive and order-reversed version of linear_ordered_comm_monoid_with_zero.
Puts an instance of linear_ordered_add_comm_monoid_with_top on with_top of any linear_ordered_add_comm_monoid and also on enat

The goal is additive valuations - see https://github.com/leanprover-community/mathlib/tree/add_valuation3

@awainverse awainverse added the awaiting-review The author would like community review of the PR label Mar 3, 2021
@eric-wieser
Copy link
Member

It would be good to get #6489 merged before this one, so that this PR can include transferring instances of this new class to submonoids.

@eric-wieser
feat(algebra/ordered_*, */sub{monoid,group,ring,semiring,field,algebr…
8ebfeef 
…a}): pullback of ordered algebraic structures under an injective map
@eric-wieser
lintfix
01601af
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 4, 2021
@jcommelin
Copy link
Member

It would be good to get #6489 merged before this one, so that this PR can include transferring instances of this new class to submonoids.

@awainverse are you ok with waiting for that PR? I expect that it moves on the merge queue in the next two hours.

@awainverse
Copy link
Collaborator Author

I don't mind waiting. If I'm too impatient I'll just throw up an add_valuation PR.

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 4, 2021
@awainverse awainverse added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 4, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 4, 2021
@eric-wieser
Copy link
Member

Alright, #6489 is on the queue. Could you also add in this PR:

  • function.injective.linear_ordered_(add_)comm_monoid
  • submonoid.to_linear_ordered_(add_)comm_monoid
  • submodule.to_linear_ordered_(add_)comm_monoid

You should be able to copy the approach verbatim from the versions without linear in the PR.

@awainverse
Copy link
Collaborator Author

Ok, this now genuinely depends on #6489, I've added those lemmas.

@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Mar 5, 2021
@github-actions
Copy link

github-actions bot commented Mar 5, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 5, 2021
@jcommelin
Copy link
Member

bors d=@eric-wieser

@bors
Copy link

bors bot commented Mar 5, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser
Copy link
Member

eric-wieser commented Mar 5, 2021 •
edited

Thanks! Just CI to wait on

bors d=@awainverse

@bors
Copy link

bors bot commented Mar 5, 2021

✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@awainverse
Copy link
Collaborator Author

bors r+

@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 5, 2021
bors bot pushed a commit that referenced this pull request Mar 5, 2021
@awainverse @eric-wieser
feat(algebra/ordered_monoid): linear_ordered_add_comm_monoid(_with_to…
cbcbe24 
…p) (#6520)

Separates out classes for `linear_ordered_(add_)comm_monoid`
Creates `linear_ordered_add_comm_monoid_with_top`, an additive and order-reversed version of `linear_ordered_comm_monoid_with_zero`.
Puts an instance of `linear_ordered_add_comm_monoid_with_top` on `with_top` of any `linear_ordered_add_comm_monoid` and also on `enat`



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Mar 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered_monoid): linear_ordered_add_comm_monoid(_with_top) [Merged by Bors] - feat(algebra/ordered_monoid): linear_ordered_add_comm_monoid(_with_top) Mar 6, 2021
@bors bors bot closed this Mar 6, 2021
@bors bors bot deleted the linear_ordered_comm_monoid branch March 6, 2021 01:08
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@awainverse @eric-wieser @b-mehta
feat(algebra/ordered_monoid): linear_ordered_add_comm_monoid(_with_to…
d87deed 
…p) (#6520)

Separates out classes for `linear_ordered_(add_)comm_monoid`
Creates `linear_ordered_add_comm_monoid_with_top`, an additive and order-reversed version of `linear_ordered_comm_monoid_with_zero`.
Puts an instance of `linear_ordered_add_comm_monoid_with_top` on `with_top` of any `linear_ordered_add_comm_monoid` and also on `enat`



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@awainverse @eric-wieser @jcommelin @bryangingechen