Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(topology/bounded_continuous_function): structure extending continuous_map #6521

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - refactor(topology/bounded_continuous_function): structure extending continuous_map #6521

wants to merge 7 commits into from

Conversation

semorrison
Copy link
Collaborator

Convert bounded_continuous_function from a subtype to a structure extending continuous_map, and some minor improvements to @[simp] lemmas.

A question: should I rename continuous_map to continuous_function, for uniformity? I'm inclined to.

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Mar 4, 2021
hrmacbeth
hrmacbeth reviewed Mar 4, 2021
View reviewed changes
Copy link
Member

@hrmacbeth hrmacbeth left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Let's make sure @sgouezel sees this, he wrote the file, and my impression that this was a desirable refactor also came from him.

I am mildly in favour of renaming continuous_map to continuous_function -- it's a shame because continuous_map is more idiomatic, but I think consistency is more important.

src/topology/bounded_continuous_function.lean Outdated Show resolved Hide resolved
src/topology/bounded_continuous_function.lean Outdated Show resolved Hide resolved
src/topology/bounded_continuous_function.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Why not go to bounded_continuous_map? Makes names shorter instead of longer?

@hrmacbeth
Copy link
Member

Why not go to bounded_continuous_map? Makes names shorter instead of longer?

The primary use of the file is X →ᵇ E with E a normed space. These are always called functions in the literature and I think it would be confusing for outsiders to do otherwise. (I think analysts don't expect to be able to add and scalar-multiply things called "maps".)

"bounded continuous function" / "bounded continuous functions", 107k + 99k Google hits
"bounded continuous map"/ "bounded continuous maps", 30k + 15k Google hits and some are "wrong" (referring to bounded, hence continuous, linear maps between normed spaces)

@jcommelin
Copy link
Member

ok, I don't know the literature, so I retract my suggestion

@semorrison @hrmacbeth
Apply suggestions from code review
b3cd18c 
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
sgouezel
sgouezel reviewed Mar 6, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/topology/bounded_continuous_function.lean Outdated Show resolved Hide resolved
src/topology/bounded_continuous_function.lean Outdated Show resolved Hide resolved
src/topology/bounded_continuous_function.lean Outdated Show resolved Hide resolved
src/topology/continuous_map.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 6, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 6, 2021
@semorrison
Copy link
Collaborator Author

bors merge

@semorrison semorrison removed the awaiting-author A reviewer has asked the author a question or requested changes label Mar 8, 2021
bors bot pushed a commit that referenced this pull request Mar 8, 2021
@semorrison
refactor(topology/bounded_continuous_function): structure extending c…
09f7eb1 
…ontinuous_map (#6521)

Convert `bounded_continuous_function` from a subtype to a structure extending `continuous_map`, and some minor improvements to `@[simp]` lemmas.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 8, 2021
@bors
Copy link

bors bot commented Mar 8, 2021

Build failed:

@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Mar 9, 2021
@semorrison
refactor(topology/bounded_continuous_function): structure extending c…
32bd00f 
…ontinuous_map (#6521)

Convert `bounded_continuous_function` from a subtype to a structure extending `continuous_map`, and some minor improvements to `@[simp]` lemmas.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Mar 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/bounded_continuous_function): structure extending continuous_map [Merged by Bors] - refactor(topology/bounded_continuous_function): structure extending continuous_map Mar 9, 2021
@bors bors bot closed this Mar 9, 2021
@bors bors bot deleted the refactor_bcf branch March 9, 2021 03:48
ocfnash pushed a commit that referenced this pull request Mar 12, 2021
@semorrison @ocfnash
refactor(topology/bounded_continuous_function): structure extending c…
ce8074b 
…ontinuous_map (#6521)

Convert `bounded_continuous_function` from a subtype to a structure extending `continuous_map`, and some minor improvements to `@[simp]` lemmas.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@semorrison @b-mehta
refactor(topology/bounded_continuous_function): structure extending c…
20ec22e 
…ontinuous_map (#6521)

Convert `bounded_continuous_function` from a subtype to a structure extending `continuous_map`, and some minor improvements to `@[simp]` lemmas.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mans0954 mans0954 mentioned this pull request Mar 2, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@hrmacbeth hrmacbeth hrmacbeth left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @jcommelin @hrmacbeth @sgouezel @bryangingechen