Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/zorn): nonempty formulation of Zorn's lemma #6532

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(order/zorn): nonempty formulation of Zorn's lemma #6532

wants to merge 4 commits into from

Conversation

b-mehta
Copy link
Collaborator

@b-mehta b-mehta commented Mar 4, 2021

In practice it's often helpful to have this alternate formulation of Zorn's lemma

@b-mehta b-mehta added the awaiting-review The author would like community review of the PR label Mar 4, 2021
jcommelin
jcommelin approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

src/order/zorn.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Mar 4, 2021

✌️ b-mehta can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@b-mehta @jcommelin
Apply suggestions from code review
248a62a 
Co-authored-by: Johan Commelin <johan@commelin.net>
@bryangingechen bryangingechen added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Mar 4, 2021
@fpvandoorn
Copy link
Member

LGTM

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 4, 2021
bors bot pushed a commit that referenced this pull request Mar 4, 2021
@b-mehta
feat(order/zorn): nonempty formulation of Zorn's lemma (#6532)
84f4d5c 
In practice it's often helpful to have this alternate formulation of Zorn's lemma
@bors
Copy link

bors bot commented Mar 4, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/zorn): nonempty formulation of Zorn's lemma [Merged by Bors] - feat(order/zorn): nonempty formulation of Zorn's lemma Mar 4, 2021
@bors bors bot closed this Mar 4, 2021
@bors bors bot deleted the nonempty-zorn branch March 4, 2021 21:17
b-mehta added a commit that referenced this pull request Apr 2, 2021
@b-mehta
feat(order/zorn): nonempty formulation of Zorn's lemma (#6532)
8422028 
In practice it's often helpful to have this alternate formulation of Zorn's lemma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@b-mehta @fpvandoorn @jcommelin @bryangingechen