[Merged by Bors] - fix(*): remove some simp lemmas #6541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are all already declared in core
fpvandoorn
added
the
awaiting-review
jcommelin
approved these changes
Mar 5, 2021
|
If there's duplication between mathlib and core that we're not addressing now, maybe the duplicate lemmas should be tagged with "TODO" comments? |
|
Thanks! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2021
All of these simp lemmas are also declared in core. Maybe one of the copies can be removed in a future PR, but this PR is just to remove the duplicate simp attributes. This is part of fixing linting problems in core, done in leanprover-community/lean#545. Most of the duplicate simp lemmas are fixed in `core`, but I prefer to remove the simp attribute here in mathlib if the simp lemmas were already used in core.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
All of these simp lemmas are also declared in core. Maybe one of the copies can be removed in a future PR, but this PR is just to remove the duplicate simp attributes. This is part of fixing linting problems in core, done in leanprover-community/lean#545. Most of the duplicate simp lemmas are fixed in `core`, but I prefer to remove the simp attribute here in mathlib if the simp lemmas were already used in core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these simp lemmas are also declared in core.
Maybe one of the copies can be removed in a future PR, but this PR is just to remove the duplicate simp attributes.
This is part of fixing linting problems in core, done in leanprover-community/lean#545.
Most of the duplicate simp lemmas are fixed in
core, but I prefer to remove the simp attribute here in mathlib if the simp lemmas were already used in core.