[Merged by Bors] - feat(algebra/algebra/{basic,tower}): add alg_equiv.comap and alg_equiv.restrict_scalars #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Mar 5, 2021
src/ring_theory/algebra_tower.lean
Outdated
| inv_fun := λ fg, @is_scalar_tower.restrict_base A _ _ _ _ _ _ _ _ _ | ||
| fg.1.to_ring_hom.to_algebra _ _ _ _ fg.2, | ||
| inv_fun := λ fg, | ||
| let alg := fg.1.to_ring_hom.to_algebra in by exactI fg.2.restrict_base A, |
There was a problem hiding this comment.
This one was fine with the underscores, but is much less fragile to argument reordering this way.
eric-wieser
added
the
awaiting-review
eric-wieser
commented
Mar 5, 2021
eric-wieser
force-pushed
the
eric-wieser/alg_equiv.comap
branch
from
7478e27
to
16d2c2a
Compare
eric-wieser
changed the title
Vierkantor
approved these changes
Mar 8, 2021
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 8, 2021
…v.restrict_scalars (#6548) This also renames `is_scalar_tower.restrict_base` to `alg_hom.restrict_scalars`, to enable dot notation and match `linear_map.restrict_scalars`.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…v.restrict_scalars (#6548) This also renames `is_scalar_tower.restrict_base` to `alg_hom.restrict_scalars`, to enable dot notation and match `linear_map.restrict_scalars`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also renames
is_scalar_tower.restrict_basetoalg_hom.restrict_scalars, to enable dot notation and matchlinear_map.restrict_scalars.