Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/topological_fiber_bundle): topological fiber bundle over [a, b] is trivial #6555

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(topology/topological_fiber_bundle): topological fiber bundle over [a, b] is trivial #6555

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 5, 2021 •
edited

@urkud urkud added the awaiting-review The author would like community review of the PR label Mar 5, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Mar 5, 2021

I assume you will refactor this in terms of local_equiv.is_image as mentioned on Zulip, so I am not reviewing this now, and setting it as WIP. If I didn't understand correctly and you want me to review this one already, please set it back to awaiting review.

@sgouezel sgouezel added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Mar 5, 2021
@urkud
Copy link
Member Author

urkud commented Mar 5, 2021

I'm sorry for forgetting to set WIP label myself: I first submitted it for review, then decided to introduce is_image.

@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Mar 10, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed merge-conflict Please `git merge origin/master` then a bot will remove this label. labels Mar 19, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 1, 2021
@urkud urkud added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 3, 2021
@urkud urkud changed the title feat(data/equiv/local_equiv): add local_equiv.piecewise feat(topology/topological_fiber_bundle): topological fiber bundle over [a, b] is trivial Apr 3, 2021
@semorrison semorrison requested a review from sgouezel April 5, 2021 22:39
sgouezel
sgouezel reviewed Apr 11, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

src/topology/topological_fiber_bundle.lean Outdated
e.trans_fiber_homeomorph h x = ((e x).1, h (e x).2) :=
rfl

/-- Coordinate transformation in the fiber induced by a pair of bundle trivializations. -/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention the homeomorphism version in this docstring, as this is the one one will use most often?

src/topology/topological_fiber_bundle.lean
(h : is_topological_fiber_bundle F proj) (a b : B) :
∃ e : bundle_trivialization F proj, Icc a b ⊆ e.base_set :=
begin
classical,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a few comments to this proof (replacing some rcases with obtain could also improve a little bit the readability, although the current version is already pretty readable)?

@urkud
Copy link
Member Author

urkud commented Apr 12, 2021

@sgouezel There was no formal bors d+, so I'm not merging yet.

@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 14, 2021
bors bot pushed a commit that referenced this pull request Apr 14, 2021
@urkud
feat(topology/topological_fiber_bundle): topological fiber bundle ove…
b3ed775 
…r `[a, b]` is trivial (#6555)
@bors
Copy link

bors bot commented Apr 14, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 14, 2021
@urkud
feat(topology/topological_fiber_bundle): topological fiber bundle ove…
2828a9a 
…r `[a, b]` is trivial (#6555)
bors bot pushed a commit that referenced this pull request Apr 14, 2021
@urkud
feat(topology/topological_fiber_bundle): topological fiber bundle ove…
f12575e 
…r `[a, b]` is trivial (#6555)
@bors
Copy link

bors bot commented Apr 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/topological_fiber_bundle): topological fiber bundle over [a, b] is trivial [Merged by Bors] - feat(topology/topological_fiber_bundle): topological fiber bundle over [a, b] is trivial Apr 14, 2021
@bors bors bot closed this Apr 14, 2021
@bors bors bot deleted the local-equiv-piecewise branch April 14, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @sgouezel