Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/valuation/basic): additive valuations #6559

Closed
wants to merge 2 commits into from

Conversation

awainverse
Copy link
Collaborator

Introduces add_valuation, a version of valuation that takes values in a linear_ordered_add_comm_monoid_with_top.
As an example, defines multiplicity.add_valuation


@awainverse awainverse added the awaiting-review The author would like community review of the PR label Mar 6, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 9, 2021
bors bot pushed a commit that referenced this pull request Mar 9, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
@bors
Copy link

bors bot commented Mar 9, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 9, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
@bors
Copy link

bors bot commented Mar 9, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 10, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
@bors
Copy link

bors bot commented Mar 10, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 10, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
@bors
Copy link

bors bot commented Mar 10, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 10, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
@bors
Copy link

bors bot commented Mar 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/valuation/basic): additive valuations [Merged by Bors] - feat(ring_theory/valuation/basic): additive valuations Mar 11, 2021
@bors bors bot closed this Mar 11, 2021
@bors bors bot deleted the add_valuation branch March 11, 2021 00:47
ocfnash pushed a commit that referenced this pull request Mar 12, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Introduces `add_valuation`, a version of `valuation` that takes values in a `linear_ordered_add_comm_monoid_with_top`.
As an example, defines `multiplicity.add_valuation`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants