Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/equiv/local_equiv,topology/local_homeomorph): put source/target to the left in #6583

Closed
wants to merge 6 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 8, 2021


@urkud urkud added the awaiting-review The author would like community review of the PR label Mar 8, 2021
@sgouezel
Copy link
Collaborator

sgouezel commented Mar 9, 2021

That's great you did this. Could you also mention this convention in the file-level docstring of local_equiv.lean?
bors d+

@bors
Copy link

bors bot commented Mar 9, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Mar 9, 2021
@urkud
Copy link
Member Author

urkud commented Mar 9, 2021

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Mar 9, 2021
bors bot pushed a commit that referenced this pull request Mar 9, 2021
@bors
Copy link

bors bot commented Mar 9, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 9, 2021
@bors
Copy link

bors bot commented Mar 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/equiv/local_equiv,topology/local_homeomorph): put source/target to the left in [Merged by Bors] - chore(data/equiv/local_equiv,topology/local_homeomorph): put source/target to the left in Mar 10, 2021
@bors bors bot closed this Mar 10, 2021
@bors bors bot deleted the local-equiv-inter-left branch March 10, 2021 02:23
ocfnash pushed a commit that referenced this pull request Mar 12, 2021
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants