[Merged by Bors] - feat(linear_algebra/quadratic_form): associated bilinear form over noncommutative rings #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
the
awaiting-review
eric-wieser
reviewed
Mar 8, 2021
eric-wieser
reviewed
Mar 8, 2021
eric-wieser
reviewed
Mar 8, 2021
eric-wieser
reviewed
Mar 8, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
2 tasks
eric-wieser
reviewed
Mar 10, 2021
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 15, 2021
…ncommutative rings (#6585) The `associated` bilinear form to a quadratic form is currently constructed for commutative rings, but nearly the same construction works without a commutativity hypothesis (the only part that fails is that the operation of performing the construction is now an `add_monoid_hom` rather than a `linear_map`. I provide this construction, naming it `associated'`. Needed for #5814 (not exactly a dependency since we can merge a non-optimal version of that PR before this one is merged). Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…ncommutative rings (#6585) The `associated` bilinear form to a quadratic form is currently constructed for commutative rings, but nearly the same construction works without a commutativity hypothesis (the only part that fails is that the operation of performing the construction is now an `add_monoid_hom` rather than a `linear_map`. I provide this construction, naming it `associated'`. Needed for #5814 (not exactly a dependency since we can merge a non-optimal version of that PR before this one is merged). Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
associatedbilinear form to a quadratic form is currently constructed for commutative rings, but nearly the same construction works without a commutativity hypothesis (the only part that fails is that the operation of performing the construction is now anadd_monoid_homrather than alinear_map. I provide this construction, naming itassociated'.Needed for #5814 (not exactly a dependency since we can merge a non-optimal version of that PR before this one is merged).
The discussion in the comments moved to
https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.236585