[Merged by Bors] - refactor(data/mv_polynomial): cleanup equivs #6589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
commented
Mar 8, 2021
github-actions
bot
added
the
blocked-by-other-PR
eric-wieser
added
the
awaiting-review
eric-wieser
commented
Mar 8, 2021
src/data/mv_polynomial/equiv.lean
Outdated
Comment on lines
262
to
264
| -- TODO: move | ||
| instance : is_scalar_tower R (mv_polynomial S₁ R) (polynomial (mv_polynomial S₁ R)) := | ||
| finsupp.is_scalar_tower ℕ _ |
There was a problem hiding this comment.
Will remove these after #6592 is merged.
|
It looks very nice! Is it now possible to get rid of some |
|
Yes, I think after this PR every use of comap can be removed. |
github-actions
bot
removed
the
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
This: * Replaces `alg_equiv_congr_left` with `rename_equiv` (to match `rename`) * Removes `ring_equiv_congr_left` (it's now `rename_equiv.to_ring_equiv`) * Renames `alg_equiv_congr_right` to `map_alg_equiv` (to match `map`) and removes the `comap` from the definition * Renames `ring_equiv_congr_right` to `map_equiv` (to match `map`) * Removes `alg_equiv_congr` (it's now `(map_alg_equiv R e).trans $ (rename_equiv e_var).restrict_scalars _`, which while longer is never used anyway) * Removes `ring_equiv_congr` (it's now `(map_equiv R e).trans $ (rename_equiv e_var).to_ring_equiv`, which while longer is never used anyway) * Replaces `punit_ring_equiv` with `punit_alg_equiv` * Removes `comap` from the definition of `sum_alg_equiv` * Promotes `option_equiv_left`, `option_equiv_right`, and `fin_succ_equiv` to `alg_equiv`s This is a follow-up to #6420
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
This: * Replaces `alg_equiv_congr_left` with `rename_equiv` (to match `rename`) * Removes `ring_equiv_congr_left` (it's now `rename_equiv.to_ring_equiv`) * Renames `alg_equiv_congr_right` to `map_alg_equiv` (to match `map`) and removes the `comap` from the definition * Renames `ring_equiv_congr_right` to `map_equiv` (to match `map`) * Removes `alg_equiv_congr` (it's now `(map_alg_equiv R e).trans $ (rename_equiv e_var).restrict_scalars _`, which while longer is never used anyway) * Removes `ring_equiv_congr` (it's now `(map_equiv R e).trans $ (rename_equiv e_var).to_ring_equiv`, which while longer is never used anyway) * Replaces `punit_ring_equiv` with `punit_alg_equiv` * Removes `comap` from the definition of `sum_alg_equiv` * Promotes `option_equiv_left`, `option_equiv_right`, and `fin_succ_equiv` to `alg_equiv`s This is a follow-up to #6420
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ocfnash
pushed a commit
that referenced
this pull request
Mar 12, 2021
This: * Replaces `alg_equiv_congr_left` with `rename_equiv` (to match `rename`) * Removes `ring_equiv_congr_left` (it's now `rename_equiv.to_ring_equiv`) * Renames `alg_equiv_congr_right` to `map_alg_equiv` (to match `map`) and removes the `comap` from the definition * Renames `ring_equiv_congr_right` to `map_equiv` (to match `map`) * Removes `alg_equiv_congr` (it's now `(map_alg_equiv R e).trans $ (rename_equiv e_var).restrict_scalars _`, which while longer is never used anyway) * Removes `ring_equiv_congr` (it's now `(map_equiv R e).trans $ (rename_equiv e_var).to_ring_equiv`, which while longer is never used anyway) * Replaces `punit_ring_equiv` with `punit_alg_equiv` * Removes `comap` from the definition of `sum_alg_equiv` * Promotes `option_equiv_left`, `option_equiv_right`, and `fin_succ_equiv` to `alg_equiv`s This is a follow-up to #6420
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
This: * Replaces `alg_equiv_congr_left` with `rename_equiv` (to match `rename`) * Removes `ring_equiv_congr_left` (it's now `rename_equiv.to_ring_equiv`) * Renames `alg_equiv_congr_right` to `map_alg_equiv` (to match `map`) and removes the `comap` from the definition * Renames `ring_equiv_congr_right` to `map_equiv` (to match `map`) * Removes `alg_equiv_congr` (it's now `(map_alg_equiv R e).trans $ (rename_equiv e_var).restrict_scalars _`, which while longer is never used anyway) * Removes `ring_equiv_congr` (it's now `(map_equiv R e).trans $ (rename_equiv e_var).to_ring_equiv`, which while longer is never used anyway) * Replaces `punit_ring_equiv` with `punit_alg_equiv` * Removes `comap` from the definition of `sum_alg_equiv` * Promotes `option_equiv_left`, `option_equiv_right`, and `fin_succ_equiv` to `alg_equiv`s This is a follow-up to #6420
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This:
alg_equiv_congr_leftwithrename_equiv(to matchrename)ring_equiv_congr_left(it's nowrename_equiv.to_ring_equiv)alg_equiv_congr_righttomap_alg_equiv(to matchmap) and removes thecomapfrom the definitionring_equiv_congr_righttomap_equiv(to matchmap)alg_equiv_congr(it's now(map_alg_equiv R e).trans $ (rename_equiv e_var).restrict_scalars _, which while longer is never used anyway)ring_equiv_congr(it's now(map_equiv R e).trans $ (rename_equiv e_var).to_ring_equiv, which while longer is never used anyway)punit_ring_equivwithpunit_alg_equivcomapfrom the definition ofsum_alg_equivoption_equiv_left,option_equiv_right, andfin_succ_equivtoalg_equivsThis is a follow-up to #6420