New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(topology/algebra/ordered): use dot notation, golf some proofs #6595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `is_lub_of_is_lub_of_tendsto` → `is_lub.is_lub_of_tendsto`; * `is_glb_of_is_glb_of_tendsto` → `is_glb.is_glb_of_tendsto`; * `is_glb_of_is_lub_of_tendsto` → `is_lub.is_glb_of_tendsto`; * `is_lub_of_is_glb_of_tendsto` → `is_glb.is_lub_of_tendsto`; * `mem_closure_of_is_lub` → `is_lub.mem_closure`; * `mem_of_is_lub_of_is_closed` → `is_lub.mem_of_is_closed`, `is_closed.is_lub_mem`; * `mem_closure_of_is_glb` → `is_glb.mem_closure`; * `mem_of_is_glb_of_is_closed` → `is_glb.mem_of_is_closed`, `is_closed.is_glb_mem`; * `is_lub.inter_Ici_of_mem` * `is_glb.inter_Iic_of_mem` * `frequently.filter_mono` * `is_lub.frequently_mem` * `is_lub.frequently_nhds_mem` * `is_glb.frequently_mem` * `is_glb.frequently_nhds_mem` * `is_lub.mem_upper_bounds_of_tendsto` * `is_glb.mem_lower_bounds_of_tendsto` * `is_lub.mem_lower_bounds_of_tendsto` * `is_glb.mem_upper_bounds_of_tendsto` * `diff_subset_closure_iff`
jcommelin
approved these changes
Mar 9, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2021
…6595) Use more precise typeclass arguments here and there, golf some proofs, use dot notation. ### Renamed lemmas * `is_lub_of_is_lub_of_tendsto` → `is_lub.is_lub_of_tendsto`; * `is_glb_of_is_glb_of_tendsto` → `is_glb.is_glb_of_tendsto`; * `is_glb_of_is_lub_of_tendsto` → `is_lub.is_glb_of_tendsto`; * `is_lub_of_is_glb_of_tendsto` → `is_glb.is_lub_of_tendsto`; * `mem_closure_of_is_lub` → `is_lub.mem_closure`; * `mem_of_is_lub_of_is_closed` → `is_lub.mem_of_is_closed`, `is_closed.is_lub_mem`; * `mem_closure_of_is_glb` → `is_glb.mem_closure`; * `mem_of_is_glb_of_is_closed` → `is_glb.mem_of_is_closed`, `is_closed.is_glb_mem`; ### New lemmas * `is_lub.inter_Ici_of_mem` * `is_glb.inter_Iic_of_mem` * `frequently.filter_mono` * `is_lub.frequently_mem` * `is_lub.frequently_nhds_mem` * `is_glb.frequently_mem` * `is_glb.frequently_nhds_mem` * `is_lub.mem_upper_bounds_of_tendsto` * `is_glb.mem_lower_bounds_of_tendsto` * `is_lub.mem_lower_bounds_of_tendsto` * `is_glb.mem_upper_bounds_of_tendsto` * `diff_subset_closure_iff`
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Mar 9, 2021
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
chore(topology/algebra/ordered): use dot notation, golf some proofs
[Merged by Bors] - chore(topology/algebra/ordered): use dot notation, golf some proofs
Mar 9, 2021
ocfnash
pushed a commit
that referenced
this pull request
Mar 12, 2021
…6595) Use more precise typeclass arguments here and there, golf some proofs, use dot notation. ### Renamed lemmas * `is_lub_of_is_lub_of_tendsto` → `is_lub.is_lub_of_tendsto`; * `is_glb_of_is_glb_of_tendsto` → `is_glb.is_glb_of_tendsto`; * `is_glb_of_is_lub_of_tendsto` → `is_lub.is_glb_of_tendsto`; * `is_lub_of_is_glb_of_tendsto` → `is_glb.is_lub_of_tendsto`; * `mem_closure_of_is_lub` → `is_lub.mem_closure`; * `mem_of_is_lub_of_is_closed` → `is_lub.mem_of_is_closed`, `is_closed.is_lub_mem`; * `mem_closure_of_is_glb` → `is_glb.mem_closure`; * `mem_of_is_glb_of_is_closed` → `is_glb.mem_of_is_closed`, `is_closed.is_glb_mem`; ### New lemmas * `is_lub.inter_Ici_of_mem` * `is_glb.inter_Iic_of_mem` * `frequently.filter_mono` * `is_lub.frequently_mem` * `is_lub.frequently_nhds_mem` * `is_glb.frequently_mem` * `is_glb.frequently_nhds_mem` * `is_lub.mem_upper_bounds_of_tendsto` * `is_glb.mem_lower_bounds_of_tendsto` * `is_lub.mem_lower_bounds_of_tendsto` * `is_glb.mem_upper_bounds_of_tendsto` * `diff_subset_closure_iff`
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…6595) Use more precise typeclass arguments here and there, golf some proofs, use dot notation. ### Renamed lemmas * `is_lub_of_is_lub_of_tendsto` → `is_lub.is_lub_of_tendsto`; * `is_glb_of_is_glb_of_tendsto` → `is_glb.is_glb_of_tendsto`; * `is_glb_of_is_lub_of_tendsto` → `is_lub.is_glb_of_tendsto`; * `is_lub_of_is_glb_of_tendsto` → `is_glb.is_lub_of_tendsto`; * `mem_closure_of_is_lub` → `is_lub.mem_closure`; * `mem_of_is_lub_of_is_closed` → `is_lub.mem_of_is_closed`, `is_closed.is_lub_mem`; * `mem_closure_of_is_glb` → `is_glb.mem_closure`; * `mem_of_is_glb_of_is_closed` → `is_glb.mem_of_is_closed`, `is_closed.is_glb_mem`; ### New lemmas * `is_lub.inter_Ici_of_mem` * `is_glb.inter_Iic_of_mem` * `frequently.filter_mono` * `is_lub.frequently_mem` * `is_lub.frequently_nhds_mem` * `is_glb.frequently_mem` * `is_glb.frequently_nhds_mem` * `is_lub.mem_upper_bounds_of_tendsto` * `is_glb.mem_lower_bounds_of_tendsto` * `is_lub.mem_lower_bounds_of_tendsto` * `is_glb.mem_upper_bounds_of_tendsto` * `diff_subset_closure_iff`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more precise typeclass arguments here and there, golf some proofs, use dot notation.
Renamed lemmas
is_lub_of_is_lub_of_tendsto
→is_lub.is_lub_of_tendsto
;is_glb_of_is_glb_of_tendsto
→is_glb.is_glb_of_tendsto
;is_glb_of_is_lub_of_tendsto
→is_lub.is_glb_of_tendsto
;is_lub_of_is_glb_of_tendsto
→is_glb.is_lub_of_tendsto
;mem_closure_of_is_lub
→is_lub.mem_closure
;mem_of_is_lub_of_is_closed
→is_lub.mem_of_is_closed
,is_closed.is_lub_mem
;mem_closure_of_is_glb
→is_glb.mem_closure
;mem_of_is_glb_of_is_closed
→is_glb.mem_of_is_closed
,is_closed.is_glb_mem
;New lemmas
is_lub.inter_Ici_of_mem
is_glb.inter_Iic_of_mem
frequently.filter_mono
is_lub.frequently_mem
is_lub.frequently_nhds_mem
is_glb.frequently_mem
is_glb.frequently_nhds_mem
is_lub.mem_upper_bounds_of_tendsto
is_glb.mem_lower_bounds_of_tendsto
is_lub.mem_lower_bounds_of_tendsto
is_glb.mem_upper_bounds_of_tendsto
diff_subset_closure_iff