Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(ring_theory/polynomial): Pochhammer polynomials #6598

Closed
wants to merge 36 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Mar 9, 2021

The Pochhammer polynomials

We define and prove some basic relations about
pochhammer S n : polynomial S = X * (X+1) * ... * (X + n - 1)
which is also known as the rising factorial.


This replaces #6435, which introduced rising_factorial and falling_factorial as functions. This PR instead introduces pochhammer as a polynomial.

@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 9, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 9, 2021
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 9, 2021
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Mar 12, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Mar 12, 2021
src/ring_theory/polynomial/pochhammer.lean Outdated Show resolved Hide resolved
src/ring_theory/polynomial/pochhammer.lean Outdated Show resolved Hide resolved
src/ring_theory/polynomial/pochhammer.lean Outdated Show resolved Hide resolved
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 17, 2021
bors bot pushed a commit that referenced this pull request Mar 17, 2021
# The Pochhammer polynomials

We define and prove some basic relations about
`pochhammer S n : polynomial S = X * (X+1) * ... * (X + n - 1)`
which is also known as the rising factorial.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Mar 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(ring_theory/polynomial): Pochhammer polynomials [Merged by Bors] - feat(ring_theory/polynomial): Pochhammer polynomials Mar 17, 2021
@bors bors bot closed this Mar 17, 2021
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
# The Pochhammer polynomials

We define and prove some basic relations about
`pochhammer S n : polynomial S = X * (X+1) * ... * (X + n - 1)`
which is also known as the rising factorial.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants