[Merged by Bors] - chore(ring_theory/polynomial/basic): remove a use of comap #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges together `quotient_equiv_quotient_mv_polynomial` and `quotient_alg_equiv_quotient_mv_polynomial`, since the two now have the same domain and codomain.
eric-wieser
added
the
awaiting-review
|
I wanted to do it myself :D Otherwise it looks good to me. |
Vierkantor
approved these changes
Mar 10, 2021
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Vierkantor
added
delegated
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2021
This merges together `quotient_equiv_quotient_mv_polynomial` and `quotient_alg_equiv_quotient_mv_polynomial`, since the two now have the same domain and codomain. `comap` was previously needed here to provide a wrapper type with an R-algebra structure on `mv_polynomial σ (I.quotient)`. The updated `mv_polynomial.algebra` in #6533 transfers the `algebra R I.quotient` structure directly to `mv_polynomial σ I.quotient`, eliminating the need for this wrapper type.
|
Build failed (retrying...): |
Closed
2 tasks
bors bot
pushed a commit
that referenced
this pull request
Mar 11, 2021
This merges together `quotient_equiv_quotient_mv_polynomial` and `quotient_alg_equiv_quotient_mv_polynomial`, since the two now have the same domain and codomain. `comap` was previously needed here to provide a wrapper type with an R-algebra structure on `mv_polynomial σ (I.quotient)`. The updated `mv_polynomial.algebra` in #6533 transfers the `algebra R I.quotient` structure directly to `mv_polynomial σ I.quotient`, eliminating the need for this wrapper type.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
ocfnash
pushed a commit
that referenced
this pull request
Mar 12, 2021
This merges together `quotient_equiv_quotient_mv_polynomial` and `quotient_alg_equiv_quotient_mv_polynomial`, since the two now have the same domain and codomain. `comap` was previously needed here to provide a wrapper type with an R-algebra structure on `mv_polynomial σ (I.quotient)`. The updated `mv_polynomial.algebra` in #6533 transfers the `algebra R I.quotient` structure directly to `mv_polynomial σ I.quotient`, eliminating the need for this wrapper type.
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
This merges together `quotient_equiv_quotient_mv_polynomial` and `quotient_alg_equiv_quotient_mv_polynomial`, since the two now have the same domain and codomain. `comap` was previously needed here to provide a wrapper type with an R-algebra structure on `mv_polynomial σ (I.quotient)`. The updated `mv_polynomial.algebra` in #6533 transfers the `algebra R I.quotient` structure directly to `mv_polynomial σ I.quotient`, eliminating the need for this wrapper type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges together
quotient_equiv_quotient_mv_polynomialandquotient_alg_equiv_quotient_mv_polynomial, since the two now have the same domain and codomain.comapwas previously needed here to provide a wrapper type with an R-algebra structure onmv_polynomial σ (I.quotient).The updated
mv_polynomial.algebrain #6533 transfers thealgebra R I.quotientstructure directly tomv_polynomial σ I.quotient, eliminating the need for this wrapper type.