Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 #6617

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 #6617

wants to merge 2 commits into from

Conversation

RemyDegenne
Copy link
Collaborator

@RemyDegenne RemyDegenne commented Mar 10, 2021 •
edited

Add bit0/bit1 lemmas for nnreal.of_real, ennreal.of_real and ennreal.to_nnreal.
With these additions, it is for example possible to prove h : ennreal.of_real (2 : ℝ) = 2 := by simp.

@RemyDegenne RemyDegenne added the awaiting-review The author would like community review of the PR label Mar 10, 2021
@RemyDegenne RemyDegenne mentioned this pull request Mar 10, 2021
Closed
4 tasks
bryangingechen
bryangingechen approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 10, 2021
bors bot pushed a commit that referenced this pull request Mar 10, 2021
@RemyDegenne
feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 (#6617
f675a86 
)

Add bit0/bit1 lemmas for `nnreal.of_real`, `ennreal.of_real` and `ennreal.to_nnreal`.
With these additions, it is for example possible to prove `h : ennreal.of_real (2 : ℝ) = 2 := by simp`.



Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
@bors
Copy link

bors bot commented Mar 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 [Merged by Bors] - feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 Mar 10, 2021
@bors bors bot closed this Mar 10, 2021
@bors bors bot deleted the ennreal_bit0 branch March 10, 2021 20:42
ocfnash pushed a commit that referenced this pull request Mar 12, 2021
@RemyDegenne @ocfnash
feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 (#6617
09ddc71 
)

Add bit0/bit1 lemmas for `nnreal.of_real`, `ennreal.of_real` and `ennreal.to_nnreal`.
With these additions, it is for example possible to prove `h : ennreal.of_real (2 : ℝ) = 2 := by simp`.



Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@RemyDegenne @b-mehta
feat(data/real/{nnreal,ennreal}): add (e)nnreal.of_real_bit0/bit1 (#6617
dca7621 
)

Add bit0/bit1 lemmas for `nnreal.of_real`, `ennreal.of_real` and `ennreal.to_nnreal`.
With these additions, it is for example possible to prove `h : ennreal.of_real (2 : ℝ) = 2 := by simp`.



Co-authored-by: Rémy Degenne <remydegenne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RemyDegenne @bryangingechen