feat(algebra/euclidean_domain): lcm #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
reviewed
Feb 1, 2019
src/algebra/euclidean_domain.lean
Outdated
| variables [decidable_eq α] | ||
|
|
||
| def lcm (x y : α) : α := | ||
| if gcd x y = 0 then 0 else x * y / gcd x y |
There was a problem hiding this comment.
Isn't the if statement unnecessary? I thought division was defined to work like this
There was a problem hiding this comment.
If that's true, then how can (/) be the quotient argument for euclidean_domain int? I'm pretty sure that 0 / 0 : int is 0.
There was a problem hiding this comment.
We're both wrong: 0/0 is undefined. See zulip.
digama0
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list