Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(algebra/euclidean_domain): div_zero #666

Merged
merged 2 commits into from
Feb 1, 2019
Merged

feat(algebra/euclidean_domain): div_zero #666

merged 2 commits into from
Feb 1, 2019

Conversation

kckennylau
Copy link
Collaborator

TO CONTRIBUTORS:

Make sure you have:

  • reviewed and applied the coding style: coding, naming
  • for tactics:
  • make sure definitions and lemmas are put in the right files
  • make sure definitions and lemmas are not redundant

If this PR is related to a discussion on Zulip, please include a link in the discussion.

For reviewers: code review check list

@kckennylau
Copy link
Collaborator Author

This PR is evil...

@ChrisHughes24
Copy link
Member

Why is it evil?

@kckennylau
Copy link
Collaborator Author

Well it's number 666

@ChrisHughes24 ChrisHughes24 merged commit ed0d24a into master Feb 1, 2019
@ChrisHughes24 ChrisHughes24 deleted the div-zero branch February 1, 2019 22:48
cipher1024 pushed a commit that referenced this pull request Feb 8, 2019
@kckennylau @ChrisHughes24
feat(algebra/euclidean_domain): add quotient_zero axiom to euclidean_…
7229208 
…domain (#666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisHughes24 ChrisHughes24 ChrisHughes24 approved these changes

Assignees

@ChrisHughes24 ChrisHughes24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kckennylau @ChrisHughes24