Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(meta/expr): monadic analogue of expr.replace #6661

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(meta/expr): monadic analogue of expr.replace #6661

wants to merge 5 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Mar 13, 2021
digama0
digama0 reviewed Mar 13, 2021
View reviewed changes
src/meta/expr.lean Outdated Show resolved Hide resolved
@bryangingechen bryangingechen added the t-meta Tactics, attributes or user commands label Mar 13, 2021
eric-wieser
eric-wieser reviewed Mar 13, 2021
View reviewed changes
src/meta/expr.lean Outdated Show resolved Hide resolved
@semorrison @eric-wieser
Update src/data/option/defs.lean
d39800d 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison
semorrison commented Mar 14, 2021
View reviewed changes
src/data/option/defs.lean Outdated Show resolved Hide resolved
@fpvandoorn
Copy link
Member

LGTM

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 15, 2021
bors bot pushed a commit that referenced this pull request Mar 15, 2021
@semorrison
feat(meta/expr): monadic analogue of expr.replace (#6661)
c358676 


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Mar 15, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(meta/expr): monadic analogue of expr.replace [Merged by Bors] - feat(meta/expr): monadic analogue of expr.replace Mar 15, 2021
@bors bors bot closed this Mar 15, 2021
@bors bors bot deleted the expr_mreplace branch March 15, 2021 22:29
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@semorrison @b-mehta
feat(meta/expr): monadic analogue of expr.replace (#6661)
e3f9eff 


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@digama0 digama0 digama0 left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) t-meta Tactics, attributes or user commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @fpvandoorn @eric-wieser @digama0 @bryangingechen