Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/padics/padic_norm): p-adic norm of primes other than p #6730

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/padics/padic_norm): p-adic norm of primes other than p #6730

wants to merge 3 commits into from

Conversation

thejohncrafter
Copy link
Collaborator

@thejohncrafter thejohncrafter commented Mar 17, 2021 •
edited by bryangingechen

The p-adic norm of q is 1 if q is another prime than p.

Open in Gitpod

@thejohncrafter thejohncrafter added the awaiting-review The author would like community review of the PR label Mar 17, 2021
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 17, 2021
@thejohncrafter thejohncrafter added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 18, 2021
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 18, 2021
bors bot pushed a commit that referenced this pull request Mar 18, 2021
@thejohncrafter
feat(data/padics/padic_norm): p-adic norm of primes other than p (#6730)
b4afd64 
The p-adic norm of `q` is `1` if `q` is another prime than `p`.
@bors
Copy link

bors bot commented Mar 18, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/padics/padic_norm): p-adic norm of primes other than p [Merged by Bors] - feat(data/padics/padic_norm): p-adic norm of primes other than p Mar 18, 2021
@bors bors bot closed this Mar 18, 2021
@bors bors bot deleted the padic_norm_primes branch March 18, 2021 19:27
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@thejohncrafter @b-mehta
feat(data/padics/padic_norm): p-adic norm of primes other than p (#6730)
fcbdb35 
The p-adic norm of `q` is `1` if `q` is another prime than `p`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@bryangingechen bryangingechen bryangingechen left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thejohncrafter @semorrison @bryangingechen