feat(ring_theory/polynomial): more operations on polynomials #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcommelin
reviewed
Feb 2, 2019
kckennylau
force-pushed
the
polynomial-operations
branch
from
693b3c7
to
c7584ae
Compare
cipher1024
force-pushed
the
master
branch
2 times, most recently
from
f623d34
to
1ed7ad1
Compare
kckennylau
force-pushed
the
polynomial-operations
branch
from
c7584ae
to
3289836
Compare
| ⟨p.support, subtype.val ∘ p.to_fun, | ||
| λ n, finsupp.mem_support_iff.trans (not_iff_not_of_iff | ||
| ⟨λ h, congr_arg subtype.val h, λ h, subtype.eq h⟩)⟩ | ||
|
|
There was a problem hiding this comment.
This is just map subtype.val, I don't think it needs to be defined again.
There was a problem hiding this comment.
This has better definitional equalities.
|
|
||
| @[simp] theorem monic_restriction {p : polynomial R} : monic (restriction p) ↔ monic p := | ||
| ⟨λ H, congr_arg subtype.val H, λ H, subtype.eq H⟩ | ||
|
|
There was a problem hiding this comment.
Does ⟨congr_arg subtype.val, subtype.eq⟩ work here.
There was a problem hiding this comment.
I don't think it would work: congr_arg is very stubborn.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
If this PR is related to a discussion on Zulip, please include a link in the discussion.
For reviewers: code review check list