Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/subalgebra): missing norm_cast lemmas about operations #6790

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(algebra/subalgebra): missing norm_cast lemmas about operations #6790

wants to merge 3 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Mar 21, 2021
@semorrison semorrison changed the title feat(algebra/subalgebra): missing norm_cast lemmas about oeprations feat(algebra/subalgebra): missing norm_cast lemmas about operations Mar 21, 2021
@eric-wieser
Copy link
Member

There are a few more from #6768 that you could add here

@semorrison
Copy link
Collaborator Author

There are a few more from #6768 that you could add here

Ah, I hadn't seen that you'd already got those there. What do you think the timeline is for that PR? Possibly I could just abandon this one and wait for it.

@eric-wieser
Copy link
Member

I intend to split that PR into pieces sometime today; I'll just push the missing lemmas on top of this PR if that's ok?

@eric-wieser eric-wieser mentioned this pull request Mar 21, 2021
Closed
1 task
@eric-wieser
Copy link
Member

@semorrison, are you happy with the changes I pushed?

@semorrison
Copy link
Collaborator Author

@semorrison, are you happy with the changes I pushed?

Yes! (Sorry, I clicked the 🎉 button below your comment, but should have been clearer!)

@eric-wieser
Copy link
Member

Do you think we need a third reviewer to sign off on this? Or can I approve your semiring lemmas and you approve my subalgebra ones?

@semorrison
Copy link
Collaborator Author

Let's do that. LGTM!

@semorrison
Copy link
Collaborator Author

(I think "new content PRs" where a maintainer substantially contributes/rewrites shouldn't be merged by that maintainer. On the other hand infrastructure work organising and fixing existing APIs don't need such a high bar for independent review, I think.)

eric-wieser
eric-wieser reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 22, 2021
bors bot pushed a commit that referenced this pull request Mar 22, 2021
@semorrison @eric-wieser
feat(algebra/subalgebra): missing norm_cast lemmas about operations (#…
f3a4c48 
…6790)




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Mar 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/subalgebra): missing norm_cast lemmas about operations [Merged by Bors] - feat(algebra/subalgebra): missing norm_cast lemmas about operations Mar 22, 2021
@bors bors bot closed this Mar 22, 2021
@bors bors bot deleted the coe_op branch March 22, 2021 13:13
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
@semorrison @eric-wieser @b-mehta
feat(algebra/subalgebra): missing norm_cast lemmas about operations (#…
c36c364 
…6790)




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@semorrison @eric-wieser