New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(analysis/normed_space/inner_product): euclidean space is a real inner product space #6799
base: master
Are you sure you want to change the base?
Conversation
urkud
commented
Mar 21, 2021
7a7eec2
to
d081e57
Compare
…inner product space
d081e57
to
0c0dadf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you expand on the motivation for this? I'm worried that this introduces a diamond:
example {ι : Type*} [fintype ι] (f : ι → Type*)
[Π i, inner_product_space ℝ (f i)] [Π i, inner_product_space 𝕜 (f i)] :
(pi_Lp.inner_product_space f : inner_product_space ℝ (pi_Lp 2 f)) =
@pi_Lp.inner_product_space_real 𝕜 _ _ _ _ _ := rfl -- times out
which would be consistent with this comment saying the instances causes problems when 𝕜 = ℝ
:
mathlib/src/analysis/inner_product_space/basic.lean
Lines 2098 to 2101 in 0c0dadf
/-- A general inner product space structure implies a real inner product structure. This is not | |
registered as an instance since it creates problems with the case `𝕜 = ℝ`, but in can be used in a | |
proof to obtain a real inner product space structure from a given `𝕜`-inner product space | |
structure. -/ |
Oh, I guess |
I don't remember why I wanted this. I remember that I didn't use these instances in the final version, then abandoned this pr. We can close it if it leads to diamonds. |