Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(analysis/normed_space/inner_product): euclidean space is a real inner product space #6799

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 21, 2021


Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Mar 21, 2021
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 28, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 24, 2021
bors bot pushed a commit that referenced this pull request Mar 14, 2023
…18577)

Extracted from #6799. Note these have rather strong requirements on `𝕜` and `𝕜''` as those are the requirements for there to be a `smul` operation.
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand on the motivation for this? I'm worried that this introduces a diamond:

example {ι : Type*} [fintype ι] (f : ι → Type*)
  [Π i, inner_product_space ℝ (f i)] [Π i, inner_product_space 𝕜 (f i)] :
  (pi_Lp.inner_product_space f : inner_product_space ℝ (pi_Lp 2 f)) =
    @pi_Lp.inner_product_space_real 𝕜 _ _ _ _ _ := rfl  -- times out

which would be consistent with this comment saying the instances causes problems when 𝕜 = ℝ:

/-- A general inner product space structure implies a real inner product structure. This is not
registered as an instance since it creates problems with the case `𝕜 = ℝ`, but in can be used in a
proof to obtain a real inner product space structure from a given `𝕜`-inner product space
structure. -/

@eric-wieser
Copy link
Member

Oh, I guess [Π i, inner_product_space ℝ (f i)] [Π i, inner_product_space 𝕜 (f i)] is illegal because it puts two different additive group structures on f i...

@eric-wieser eric-wieser removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 15, 2023
@urkud
Copy link
Member Author

urkud commented Mar 15, 2023

I don't remember why I wanted this. I remember that I didn't use these instances in the final version, then abandoned this pr. We can close it if it leads to diamonds.

@semorrison semorrison added the too-late This PR was ready too late for inclusion in mathlib3 label Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes too-late This PR was ready too late for inclusion in mathlib3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants