Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(data/equiv/fin): rename sum_fin_sum_equiv to fin_sum_fin_equiv #6857

Closed
wants to merge 2 commits into from

Conversation

paulvanwamelen
Copy link
Collaborator

@paulvanwamelen paulvanwamelen commented Mar 25, 2021

Renames sum_fin_sum_equiv to fin_sum_fin_equiv (as discussed
on Zulip)
Introduces a version with fin(n + m) instead of fin(m + n)
Adds a bunch of simp lemmas for applying these (and their inverses)

@semorrison semorrison changed the title feat(data/equiv/fin): Equivalence of fin m ⊕ fin n and fin (m + n) or fin(n + m) feat(data/equiv/fin): rename sum_fin_sum_equiv to fin_sum_fin_equiv Mar 25, 2021
src/data/equiv/fin.lean Outdated Show resolved Hide resolved
@semorrison semorrison added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 26, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 28, 2021
@semorrison
Copy link
Collaborator

(Just a reminder that without switching the labels back from awaiting-author to awaiting-review, maintainers may not come by. :-)

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Mar 28, 2021
bors bot pushed a commit that referenced this pull request Mar 28, 2021
…6857)

Renames `sum_fin_sum_equiv` to `fin_sum_fin_equiv` (as discussed 
[on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/sum_fin_add_comm_equiv))
Introduces a version with `fin(n + m)` instead of `fin(m + n)` 
Adds a bunch of simp lemmas for applying these (and their inverses)
@bors
Copy link

bors bot commented Mar 29, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Mar 29, 2021
…6857)

Renames `sum_fin_sum_equiv` to `fin_sum_fin_equiv` (as discussed 
[on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/sum_fin_add_comm_equiv))
Introduces a version with `fin(n + m)` instead of `fin(m + n)` 
Adds a bunch of simp lemmas for applying these (and their inverses)
@bors
Copy link

bors bot commented Mar 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/equiv/fin): rename sum_fin_sum_equiv to fin_sum_fin_equiv [Merged by Bors] - feat(data/equiv/fin): rename sum_fin_sum_equiv to fin_sum_fin_equiv Mar 29, 2021
@bors bors bot closed this Mar 29, 2021
@bors bors bot deleted the fin_sum_fin branch March 29, 2021 05:18
b-mehta pushed a commit that referenced this pull request Apr 2, 2021
…6857)

Renames `sum_fin_sum_equiv` to `fin_sum_fin_equiv` (as discussed 
[on Zulip](https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/sum_fin_add_comm_equiv))
Introduces a version with `fin(n + m)` instead of `fin(m + n)` 
Adds a bunch of simp lemmas for applying these (and their inverses)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants