[Merged by Bors] - refactor(representation_theory/maschke): replaces ¬(ring_char k ∣ fintype.card G) with invertible (fintype.card G : k) instance
#6901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awainverse
added
the
awaiting-review
semorrison
reviewed
Mar 26, 2021
awainverse
changed the title
¬(ring_char k ∣ fintype.card G) a fact instance¬(ring_char k ∣ fintype.card G) with invertible (fintype.card G : k) instance
semorrison
reviewed
Mar 27, 2021
semorrison
added
awaiting-author
|
bors d+ |
|
✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with |
awainverse
added
awaiting-review
|
bors r+ |
|
Already running a review |
bors bot
pushed a commit
that referenced
this pull request
Mar 27, 2021
…ntype.card G)` with `invertible (fintype.card G : k)` instance (#6901) Refactors Maschke's theorem to take an instance of `invertible (fintype.card G : k)` instead of an explicit `not_dvd : ¬(ring_char k ∣ fintype.card G)`. Provides that instance in the context `char_zero k`. Allows `monoid_algebra.submodule.is_complemented` to be an instance.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
¬(ring_char k ∣ fintype.card G) with invertible (fintype.card G : k) instance¬(ring_char k ∣ fintype.card G) with invertible (fintype.card G : k) instance
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…ntype.card G)` with `invertible (fintype.card G : k)` instance (#6901) Refactors Maschke's theorem to take an instance of `invertible (fintype.card G : k)` instead of an explicit `not_dvd : ¬(ring_char k ∣ fintype.card G)`. Provides that instance in the context `char_zero k`. Allows `monoid_algebra.submodule.is_complemented` to be an instance.
YaelDillies
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors Maschke's theorem to take an instance of
invertible (fintype.card G : k)instead of an explicitnot_dvd : ¬(ring_char k ∣ fintype.card G).Provides that instance in the context
char_zero k.Allows
monoid_algebra.submodule.is_complementedto be an instance.