Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(algebra/add_torsor): use to_additive for add_action #6914

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - refactor(algebra/add_torsor): use to_additive for add_action #6914

wants to merge 14 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Mar 27, 2021

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Mar 27, 2021
@urkud @eric-wieser
Update src/group_theory/group_action/defs.lean
e03bce9 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
semorrison
semorrison approved these changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice! Well spotted that this refactor was possible.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Mar 28, 2021
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Mar 29, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 30, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Mar 30, 2021
eric-wieser
eric-wieser reviewed Apr 1, 2021
View reviewed changes
src/algebra/add_torsor.lean
@@ -72,87 +60,23 @@ class add_torsor (G : out_param Type*) (P : Type*) [out_param $ add_group G]
(vadd_vsub' : ∀ (g : G) (p : P), g +ᵥ p -ᵥ p = g)

attribute [instance, priority 100, nolint dangerous_instance] add_torsor.nonempty

end old_structure_cmd
attribute [nolint dangerous_instance] add_torsor.to_has_vsub
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this now appear?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. This may be related to the fact that add_action and add_torsor don't use old_structure_cmd anymore.

jcommelin
jcommelin approved these changes Apr 2, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 2, 2021
bors bot pushed a commit that referenced this pull request Apr 2, 2021
@urkud
refactor(algebra/add_torsor): use to_additive for add_action (#6914)
267e660
@bors
Copy link

bors bot commented Apr 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/add_torsor): use to_additive for add_action [Merged by Bors] - refactor(algebra/add_torsor): use to_additive for add_action Apr 3, 2021
@bors bors bot closed this Apr 3, 2021
@bors bors bot deleted the smul-to-add branch April 3, 2021 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@semorrison semorrison semorrison approved these changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @eric-wieser @semorrison @jcommelin