[Merged by Bors] - feat(group_theory/{subgroup, order_of_element}): refactors simple groups, classifies finite simple abelian/solvable groups #6926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awainverse
added
the
awaiting-review
awainverse
changed the title
semorrison
reviewed
Mar 28, 2021
semorrison
reviewed
Mar 28, 2021
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
…ups, classifies finite simple abelian/solvable groups (#6926) Refactors the deprecated `simple_group` to a new `is_simple_group` Shows that all cyclic groups of prime order are simple Shows that all simple `comm_group`s are cyclic Shows that all simple finite `comm_group`s have prime order Shows that a simple group is solvable iff it is commutative
|
Build failed: |
bryangingechen
added
awaiting-author
|
Feel free to merge after fixing the lint |
|
✌️ awainverse can now approve this pull request. To approve and merge a pull request, simply reply with |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
…ups, classifies finite simple abelian/solvable groups (#6926) Refactors the deprecated `simple_group` to a new `is_simple_group` Shows that all cyclic groups of prime order are simple Shows that all simple `comm_group`s are cyclic Shows that all simple finite `comm_group`s have prime order Shows that a simple group is solvable iff it is commutative
|
Build failed (retrying...): |
|
Canceled. |
|
I'm not sure why that build failed, the part of the file that failed wasn't a change, and didn't seem to match either my version or the master version... I've merged master, gonna try CI again. |
awainverse
removed
the
awaiting-author
|
bors r+, this is the fault of 6768 which goes stale very quickly |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 29, 2021
…ups, classifies finite simple abelian/solvable groups (#6926) Refactors the deprecated `simple_group` to a new `is_simple_group` Shows that all cyclic groups of prime order are simple Shows that all simple `comm_group`s are cyclic Shows that all simple finite `comm_group`s have prime order Shows that a simple group is solvable iff it is commutative
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
b-mehta
pushed a commit
that referenced
this pull request
Apr 2, 2021
…ups, classifies finite simple abelian/solvable groups (#6926) Refactors the deprecated `simple_group` to a new `is_simple_group` Shows that all cyclic groups of prime order are simple Shows that all simple `comm_group`s are cyclic Shows that all simple finite `comm_group`s have prime order Shows that a simple group is solvable iff it is commutative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the deprecated
simple_groupto a newis_simple_groupShows that all cyclic groups of prime order are simple
Shows that all simple
comm_groups are cyclicShows that all simple finite
comm_groups have prime orderShows that a simple group is solvable iff it is commutative