Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(group_theory/specific_groups/*): new folder specific_groups #7018

Closed
wants to merge 4 commits into from

Conversation

Julian-Kuelshammer
Copy link
Collaborator

@Julian-Kuelshammer Julian-Kuelshammer commented Apr 3, 2021

This creates a new folder specific_groups analogous to analysis.special_functions. So far, I have put cyclic (split from order_of_element), dihedral, and quaternion there.

Related Zulip discussion:
https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/group_theory.2Especific_groups


Open in Gitpod

@Julian-Kuelshammer Julian-Kuelshammer added the awaiting-review The author would like community review of the PR label Apr 3, 2021
@jcommelin
Copy link
Member

@Julian-Kuelshammer Just to be clear: there is no new material here, right?
If so, please point out the new material, so that it can be reviewed.

@jcommelin
Copy link
Member

Potential conflict: #6949

@Julian-Kuelshammer
Copy link
Collaborator Author

Julian-Kuelshammer commented Apr 3, 2021

@Julian-Kuelshammer Just to be clear: there is no new material here, right?
If so, please point out the new material, so that it can be reviewed.

The only "new material" is the module doc for cyclic all the rest is copy-pasted.

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 6, 2021
bors bot pushed a commit that referenced this pull request Apr 7, 2021
)

This creates a new folder `specific_groups` analogous to `analysis.special_functions`. So far, I have put `cyclic` (split from `order_of_element`), `dihedral`, and `quaternion` there.

Related Zulip discussion: 
https://leanprover.zulipchat.com/#narrow/stream/113488-general/topic/group_theory.2Especific_groups
@bors
Copy link

bors bot commented Apr 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/specific_groups/*): new folder specific_groups [Merged by Bors] - chore(group_theory/specific_groups/*): new folder specific_groups Apr 7, 2021
@bors bors bot closed this Apr 7, 2021
@bors bors bot deleted the specific_groups branch April 7, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants