Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/normed_space/finite_dimension): set of f : E →L[𝕜] F of rank ≥n is open #7022

Closed
wants to merge 9 commits into from

Conversation

* move `@[simp]` from `linear_map.comp_apply` to new
  `linear_map.coe_comp`;
* rename `linear_map.comp_coe` to `linear_map.coe_comp`, swap LHS&RHS;
* add `linear_map.coe_proj`, move `@[simp]` from `linear_map.proj_apply`.
@urkud urkud added the awaiting-review The author would like community review of the PR label Apr 3, 2021
@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 3, 2021
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

@@ -85,6 +85,18 @@ begin
{ intro i, exact (h i).map_zero },
end

variable (R)

/-- Given `fintype α`, `linear_equiv_fun_on_fintype R` is the natural `R`-linear between `α →₀ β`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing map in the docstring.

@@ -141,6 +142,11 @@ begin
rw [hg i hi, zero_smul]
end

theorem fintype.linear_independent_iff' [fintype ι] :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one would deserve a docstring, because the second term is hard to read.

@bors
Copy link

bors bot commented Apr 10, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@urkud
Copy link
Member Author

urkud commented Apr 11, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 11, 2021
bors bot pushed a commit that referenced this pull request Apr 11, 2021
@bors
Copy link

bors bot commented Apr 11, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/normed_space/finite_dimension): set of f : E →L[𝕜] F of rank ≥n is open [Merged by Bors] - feat(analysis/normed_space/finite_dimension): set of f : E →L[𝕜] F of rank ≥n is open Apr 11, 2021
@bors bors bot closed this Apr 11, 2021
@bors bors bot deleted the open-lin-indep branch April 11, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants