Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(archive/imo): formalize IMO 2008 Q3 #7025

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(archive/imo): formalize IMO 2008 Q3 #7025

wants to merge 4 commits into from

Conversation

manuelcandales
Copy link
Collaborator

@manuelcandales manuelcandales commented Apr 3, 2021 •
edited by bryangingechen

Open in Gitpod

@manuelcandales manuelcandales added awaiting-review The author would like community review of the PR imo Formalisation of an IMO problem labels Apr 3, 2021
Julian-Kuelshammer
Julian-Kuelshammer reviewed Apr 5, 2021
View reviewed changes
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
archive/imo/imo2008_q3.lean Outdated Show resolved Hide resolved
@fpvandoorn
Copy link
Member

You can open real at the top, so that real.sqrt can be abbreviated to sqrt in the file. Other than that, LGTM.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 6, 2021
@manuelcandales manuelcandales added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 6, 2021
@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 8, 2021
bors bot pushed a commit that referenced this pull request Apr 8, 2021
@manuelcandales
feat(archive/imo): formalize IMO 2008 Q3 (#7025)
c6b0636
@bors
Copy link

bors bot commented Apr 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(archive/imo): formalize IMO 2008 Q3 [Merged by Bors] - feat(archive/imo): formalize IMO 2008 Q3 Apr 8, 2021
@bors bors bot closed this Apr 8, 2021
@bors bors bot deleted the imo2008_q3 branch April 8, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@Julian-Kuelshammer Julian-Kuelshammer Julian-Kuelshammer left review comments

Assignees
No one assigned
Labels
imo Formalisation of an IMO problem ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@manuelcandales @fpvandoorn @semorrison @Julian-Kuelshammer @jcommelin