Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(group_theory/order_of_element): move some lemmas #7031

Closed
wants to merge 9 commits into from

Conversation

Julian-Kuelshammer
Copy link
Collaborator

@Julian-Kuelshammer Julian-Kuelshammer commented Apr 4, 2021

I moved a few lemmas to group_theory.subgroup and to group_theory.coset and to data.finset.basic. Feel free to suggest different locations if they don't quite fit. This resolves #1563.

Renamed card_trivial to subgroup.card_bot


Open in Gitpod

@Julian-Kuelshammer Julian-Kuelshammer added WIP Work in progress awaiting-review The author would like community review of the PR labels Apr 4, 2021
@Julian-Kuelshammer Julian-Kuelshammer removed the WIP Work in progress label Apr 4, 2021
Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you're already in the subgroup namespace. If so, these suggestions will give the correct names.

bors d+

src/group_theory/subgroup.lean Outdated Show resolved Hide resolved
src/group_theory/subgroup.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Apr 5, 2021

✌️ Julian-Kuelshammer can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Julian-Kuelshammer and others added 2 commits April 5, 2021 21:42
Co-authored-by: Floris van Doorn <fpvdoorn@gmail.com>
@Julian-Kuelshammer Julian-Kuelshammer added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 5, 2021
@Julian-Kuelshammer
Copy link
Collaborator Author

bors r+

@Julian-Kuelshammer Julian-Kuelshammer added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 6, 2021
bors bot pushed a commit that referenced this pull request Apr 6, 2021
I moved a few lemmas to `group_theory.subgroup` and to `group_theory.coset` and to `data.finset.basic`. Feel free to suggest different locations if they don't quite fit. This resolves #1563.

Renamed `card_trivial` to `subgroup.card_bot`



Co-authored-by: Julian-Kuelshammer <68201724+Julian-Kuelshammer@users.noreply.github.com>
@bors
Copy link

bors bot commented Apr 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/order_of_element): move some lemmas [Merged by Bors] - chore(group_theory/order_of_element): move some lemmas Apr 6, 2021
@bors bors bot closed this Apr 6, 2021
@bors bors bot deleted the move_lemmas branch April 6, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

order of element
2 participants