Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/nat): use notation n!, minor golf #7032

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(data/nat): use notation n!, minor golf #7032

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 4, 2021

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Apr 4, 2021
bryangingechen
bryangingechen approved these changes Apr 4, 2021
View reviewed changes
Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 4, 2021
bors bot pushed a commit that referenced this pull request Apr 4, 2021
@urkud
chore(data/nat): use notation n!, minor golf (#7032)
532e5cc
@bors
Copy link

bors bot commented Apr 4, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 4, 2021
@urkud
chore(data/nat): use notation n!, minor golf (#7032)
c7d7d83
@bors
Copy link

bors bot commented Apr 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/nat): use notation n!, minor golf [Merged by Bors] - chore(data/nat): use notation n!, minor golf Apr 5, 2021
@bors bors bot closed this Apr 5, 2021
@bors bors bot deleted the nat-choose branch April 5, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @bryangingechen