Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(logic/basic): subsingleton_of_not_nonempty #7043

Closed
wants to merge 1 commit into from

Conversation

pechersky
Copy link
Collaborator

Also generalize not_nonempty_iff_imp_false to Sort *.


Open in Gitpod

@pechersky pechersky changed the title feat(logic/basic): singleton_of_not_nonempty feat(logic/basic): subsingleton_of_not_nonempty Apr 5, 2021
@pechersky pechersky added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 5, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Apr 5, 2021

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@fpvandoorn
Copy link
Member

@eric-wieser any reason to delegate instead of merge?

@fpvandoorn fpvandoorn added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 5, 2021
@eric-wieser
Copy link
Member

Mainly so as to wait to see if CI passes

@eric-wieser
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 5, 2021
Also generalize `not_nonempty_iff_imp_false` to `Sort *`.
@eric-wieser eric-wieser added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Apr 5, 2021
@fpvandoorn
Copy link
Member

Ok, makes sense. Next time I'll see that I'll feel free to merge if I see that the CI has passed.

@bors
Copy link

bors bot commented Apr 6, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(logic/basic): subsingleton_of_not_nonempty [Merged by Bors] - feat(logic/basic): subsingleton_of_not_nonempty Apr 6, 2021
@bors bors bot closed this Apr 6, 2021
@bors bors bot deleted the pechersky/subsing-of-not-nonempt branch April 6, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants