[Merged by Bors] - feat(continuous_function/compact): lemmas characterising norm and dist #7054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
semorrison
added
the
awaiting-review
eric-wieser
reviewed
Apr 6, 2021
Comment on lines
80
to
81
| lemma dist_le_of_nonempty [nonempty α] : | ||
| dist f g ≤ C ↔ ∀ x, dist (f x) (g x) ≤ C := |
There was a problem hiding this comment.
This name seems odd - the statement is essentially the same as dist_lt_iff_of_nonempty, but dist_le_of_nonempty does not have iff in its name.
There was a problem hiding this comment.
I had just been following the names used in bounded_continuous_function. I've added an extra _iff in both places.
This does leave a discrepancy still: perhaps dist_le itself should be renamed to dist_le_iff? (In both bounded_continuous_function and continuous_map.)
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 7, 2021
#7054) Transport lemmas charactering the norm and distance on bounded continuous functions, to continuous maps with compact domain. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transport lemmas charactering the norm and distance on bounded continuous functions, to continuous maps with compact domain.
Splitting off a piece of #6497 for easier review.