Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/minpoly): remove is_integral requirement from unique' #7064

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(field_theory/minpoly): remove is_integral requirement from unique' #7064

wants to merge 2 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Apr 6, 2021 •
edited

unique' had an extraneous requirement on is_integral, which could be inferred from the other arguments.

This is a small step towards #5258, but is a breaking change; unique' now needs one less argument, which will break all current code using unique'.

Open in Gitpod

@ericrbg ericrbg requested a review from tb65536 April 6, 2021 16:28
@ericrbg
Copy link
Collaborator Author

ericrbg commented Apr 6, 2021

Also, the way I tried to find breakages without having to build was using VSCode search on minpoly.unique' and open minpoly, and then trawl through myself. Is there a better way to do this?

@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Apr 6, 2021
@tb65536
Copy link
Collaborator

tb65536 commented Apr 6, 2021 •
edited

Thanks for spotting this! I would just do a VSCode search for unique', try to get as many as you can, and then see if any errors pop up during the build on github.

Update: It looks like you got them all!

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 6, 2021
bors bot pushed a commit that referenced this pull request Apr 6, 2021
@ericrbg
feat(field_theory/minpoly): remove is_integral requirement from `un…
29411e9 
…ique'` (#7064)

`unique'` had an extraneous requirement on `is_integral`, which could be inferred from the other arguments.

This is a small step towards #5258, but is a breaking change; `unique'` now needs one less argument, which will break all current code using `unique'`.
@bors
Copy link

bors bot commented Apr 7, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Apr 7, 2021
@ericrbg
feat(field_theory/minpoly): remove is_integral requirement from `un…
d89bfc4 
…ique'` (#7064)

`unique'` had an extraneous requirement on `is_integral`, which could be inferred from the other arguments.

This is a small step towards #5258, but is a breaking change; `unique'` now needs one less argument, which will break all current code using `unique'`.
@bors
Copy link

bors bot commented Apr 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/minpoly): remove is_integral requirement from unique' [Merged by Bors] - feat(field_theory/minpoly): remove is_integral requirement from unique' Apr 7, 2021
@bors bors bot closed this Apr 7, 2021
@bors bors bot deleted the irr_minpoly branch April 7, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tb65536 tb65536 tb65536 approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericrbg @tb65536 @jcommelin