-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(data/fintype/basic): to_finset lattice lemmas #7077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pechersky
added
the
awaiting-review
The author would like community review of the PR
label
Apr 7, 2021
eric-wieser
reviewed
Apr 7, 2021
eric-wieser
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 7, 2021
pechersky
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Apr 8, 2021
eric-wieser
reviewed
Apr 8, 2021
pechersky
commented
Apr 8, 2021
pechersky
commented
Apr 8, 2021
pechersky
commented
Apr 8, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Thanks! bors d+ |
✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with |
eric-wieser
added
delegated
The PR author may merge after reviewing final suggestions.
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 8, 2021
bors r+ |
4 tasks
bors bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
While we do not have lattice homomorphisms, we can still provide some similar API. Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
6 tasks
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(data/fintype/basic): to_finset lattice lemmas
[Merged by Bors] - feat(data/fintype/basic): to_finset lattice lemmas
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we do not have lattice homomorphisms, we can still provide some similar API.