[Merged by Bors] - feat(data/option/basic): option valued choice operator #7101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
the
awaiting-review
eric-wieser
reviewed
Apr 8, 2021
| else | ||
| none | ||
|
|
||
| lemma choice_eq {α : Type*} [subsingleton α] (a : α) : choice α = some a := |
There was a problem hiding this comment.
Ah, it can't be due to a. But perhaps unique is better anyway?
Suggested change
| lemma choice_eq {α : Type*} [subsingleton α] (a : α) : choice α = some a := | |
| @[simp] | |
| lemma choice_eq {α : Type*} [unique α] : choice α = some (default a) := |
There was a problem hiding this comment.
I'll add this as a separate lemma, but actually for the sake of dependent types the first one is actually useful: using subsingleton you can rewrite choice α as the particular some a that you want!
There was a problem hiding this comment.
Ah, unique isn't even defined yet here.
|
LGTM. @eric-wieser , do you have any objections left? |
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 9, 2021
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this in the new development of chain complex / homology.