[Merged by Bors] - refactor(geometry/manifold): redefine some instances #7124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gebner Could you please explain why implicit/explicit args matter here? Currently your commits look like black magic to me. |
|
The implicit/explicit args don't matter at all---for leanchecker. But apparently the elaborator now needs a little help with the new version of unique_diff_on. It can no longer figure out the second |
urkud
commented
Apr 12, 2021
urkud
added
awaiting-review
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
…/mathlib into real-instance
There are no coercions from `euclidean_half_space n` or `euclidean_quadrant n` to `euclidean_space ℝ (fin n)`
urkud
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 22, 2021
* Turn `unique_diff_within_at` into a `structure`. * Generalize `tangent_cone_at`, `unique_diff_within_at`, and `unique_diff_on` to a `semimodule` that is a `topological_space`. * Redefine `model_with_corners_euclidean_half_space` and `model_with_corners_euclidean_quadrant` to reuse more generic lemmas, including `unique_diff_on.pi` and `unique_diff_on.univ_pi`. * Make `model_with_corners.unique_diff'` use `target` instead of `range I`; usually it has better defeq. Co-authored-by: @gebner Co-authored-by: Gabriel Ebner <gebner@gebner.org>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unique_diff_within_atinto astructure.tangent_cone_at,unique_diff_within_at, andunique_diff_onto asemimodulethat is atopological_space.model_with_corners_euclidean_half_spaceandmodel_with_corners_euclidean_quadrantto reuse more generic lemmas, includingunique_diff_on.piandunique_diff_on.univ_pi.model_with_corners.unique_diff'usetargetinstead ofrange I; usually it has better defeq.Co-authored-by: @gebner