[Merged by Bors] - chore(*): speedup slow proofs #7148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgouezel
added
the
awaiting-review
semorrison
reviewed
Apr 10, 2021
Comment on lines
-56
to
+58
| change algebra R (sections_subalgebra F), | ||
| have : algebra R (types.limit_cone (F ⋙ forget (Algebra.{v} R))).X | ||
| = algebra R (sections_subalgebra F), by refl, | ||
| rw this, |
There was a problem hiding this comment.
Wow, it's sad that this speeds things up.
There was a problem hiding this comment.
Yes, a lot of things in this PR are really weird. Here, it even changes the algebra structure that is inferred (see the next change in the PR, adding a convert).
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2021
Some proofs using heavy `rfl` or heavy `obviously` can be sped up considerably. Done in this PR for some outstanding examples.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
eric-wieser
reviewed
Apr 10, 2021
| @@ -84,7 +84,7 @@ begin | |||
| letI : normed_space ℝ F := normed_space.restrict_scalars _ 𝕜 _, | |||
| -- Let `fr: p →L[ℝ] ℝ` be the real part of `f`. | |||
| let fr := re_clm.comp (f.restrict_scalars ℝ), | |||
| have fr_apply : ∀ x, fr x = re (f x) := λ x, rfl, | |||
| have fr_apply : ∀ x, fr x = re (f x), by { assume x, refl }, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some proofs using heavy
rflor heavyobviouslycan be sped up considerably. Done in this PR for some outstanding examples.Cherry-picked from #7084, in which all the original proofs fixed in this PR timed out because of the added complexity to the definition of
monoids andadd_monoids. I don't know how long #7084 will take to get merged (or if it will ever get merged), but these seem good to have anyway, as shaving a few minutes from every mathlib compilations can only help.