Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(category_theory): replace has_hom with quiver #7151

Closed
wants to merge 24 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented Apr 10, 2021

@semorrison semorrison added the RFC Request for comment label Apr 10, 2021
@semorrison semorrison requested a review from dwarn April 10, 2021 11:49
Co-authored-by: David Wärn <codwarn@gmail.com>
@semorrison semorrison changed the base branch from quiver2 to master April 11, 2021 10:17
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 11, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed RFC Request for comment labels Apr 11, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 20, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 20, 2021
@dwarn
Copy link
Collaborator

dwarn commented Apr 21, 2021

Can we split combinatorics/quiver.lean into multiple files? Otherwise, LGTM! This opens up the possibility to unify things like quiver.total / category_theory.arrow, quiver.weakly_connected_components / category_theory.connected_components, and subquivers / subcategories.

@semorrison
Copy link
Collaborator Author

Definitely. I think that's a good idea. How would you feel about doing this in a subsequent PR?

@dwarn
Copy link
Collaborator

dwarn commented Apr 21, 2021

Sure, I can do that.

@b-mehta
Copy link
Collaborator

b-mehta commented Apr 21, 2021

This seems sensible to me - @semorrison are you happy to merge this?

@semorrison
Copy link
Collaborator Author

@b-mehta yes please!

@b-mehta
Copy link
Collaborator

b-mehta commented Apr 22, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 22, 2021
bors bot pushed a commit that referenced this pull request Apr 22, 2021



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Apr 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory): replace has_hom with quiver [Merged by Bors] - chore(category_theory): replace has_hom with quiver Apr 22, 2021
@bors bors bot closed this Apr 22, 2021
@bors bors bot deleted the quiver3 branch April 22, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants