Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(measure_theory): links between an integral and its improper version #7164

Closed
wants to merge 49 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Apr 11, 2021

This PR introduces ways of studying and computing ∫ x, f x ∂μ by studying the limit of the sequence ∫ x in φ n, f x ∂μ for an appropriate sequence φ of subsets of the domain of f.


Open in Gitpod

There are a few things I'm not 100% happy with in this PR, so I'm open to suggestions. These are :

  • the name of the new file (currently integral_eq_improper.lean)
  • the name mono_ae_cover which isn't really clear
  • the definition of mono_ae_cover involves some assumptions which may be a bit too strong, but I had some troubles when trying to loosen them
  • in the part about Ixxs, I found myself duplicating a few things between the "prove f is integrable" and "integral of f is ..." versions of the lemmas, but factoring things out involves stating a lot of lemmas which won't be useful to anything else, so I'm not sure if I should do it

@ADedecker ADedecker added the WIP Work in progress label Apr 11, 2021
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 12, 2021
Copy link
Collaborator

@benjamindavidson benjamindavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions for improving the syntax in the docstrings (most of these are just things that I think read better, not actual corrections).

src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
@benjamindavidson
Copy link
Collaborator

Something strange: The name of this branch is mathlib-integral_limits (not mathlib_integral_limits). I think this prevented me from being able to clone the branch using leanproject get.

@ADedecker ADedecker added WIP Work in progress and removed awaiting-review The author would like community review of the PR labels Apr 13, 2021
@ADedecker
Copy link
Member Author

Thanks for the review @benjamindavidson, I should definitely try to improve my English. I'm tagging this as WIP again because I just found a way to make everything easier to use by extending growing_family to any sequence indexed by an archimedean ordered semiring, which avoids having to deal with coe in concrete applications. I should be able to finish this small refactor soon.

@benjamindavidson
Copy link
Collaborator

@ADedecker Your English is fine!!! Like I said, most of these are not corrections as much as they are preferences.

@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 15, 2021
Co-authored-by: Benjamin Davidson <68528197+benjamindavidson@users.noreply.github.com>
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 26, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 14, 2021
bors bot pushed a commit that referenced this pull request Jun 11, 2021
…#7828)

These are lemmas I proved while working on #7164. Some of them are actually not used anymore in that PR because I'm refactoring it, but I thought they would be useful anyway, so here there are.
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 13, 2021
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
(λ n, lintegral_indicator f (hφ.measurable n))

lemma ae_cover.lintegral_tendsto_of_nat {φ : ℕ → set α} (hφ : ae_cover μ at_top φ)
{f : α → ℝ≥0∞} (hfm : measurable f) :
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this lemma, you are assuming that f is measurable. However, I think you can easily deduce from this one a version assuming only that f is almost everywhere measurable. From there, you can weaken all the assumptions in the subsequent lemmas, from measurability to almost everywhere measurability.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of just using the measurable version to prove the ae_measurable one, I added a few lemmas to integrable_on.lean about ae-measurability of an indicator, which allows me to use ae_measurable all the way. Should I move these to a separate PR ?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 14, 2021
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 16, 2021
@bors
Copy link

bors bot commented Jun 18, 2021

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!
bors d+

src/measure_theory/integrable_on.lean Outdated Show resolved Hide resolved
src/measure_theory/integral_eq_improper.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 18, 2021
@ADedecker
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 18, 2021
…ion (#7164)

This PR introduces ways of studying and computing `∫ x, f x ∂μ` by studying the limit of the sequence `∫ x in φ n, f x ∂μ` for an appropriate sequence `φ` of subsets of the domain of `f`.
@bors
Copy link

bors bot commented Jun 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(measure_theory): links between an integral and its improper version [Merged by Bors] - feat(measure_theory): links between an integral and its improper version Jun 19, 2021
@bors bors bot closed this Jun 19, 2021
@bors bors bot deleted the integral_limits branch June 19, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants