-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(measure_theory): links between an integral and its improper version #7164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some suggestions for improving the syntax in the docstrings (most of these are just things that I think read better, not actual corrections).
Something strange: The name of this branch is |
Thanks for the review @benjamindavidson, I should definitely try to improve my English. I'm tagging this as WIP again because I just found a way to make everything easier to use by extending |
@ADedecker Your English is fine!!! Like I said, most of these are not corrections as much as they are preferences. |
Co-authored-by: Benjamin Davidson <68528197+benjamindavidson@users.noreply.github.com>
(λ n, lintegral_indicator f (hφ.measurable n)) | ||
|
||
lemma ae_cover.lintegral_tendsto_of_nat {φ : ℕ → set α} (hφ : ae_cover μ at_top φ) | ||
{f : α → ℝ≥0∞} (hfm : measurable f) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this lemma, you are assuming that f
is measurable. However, I think you can easily deduce from this one a version assuming only that f
is almost everywhere measurable. From there, you can weaken all the assumptions in the subsequent lemmas, from measurability to almost everywhere measurability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of just using the measurable
version to prove the ae_measurable
one, I added a few lemmas to integrable_on.lean
about ae-measurability of an indicator, which allows me to use ae_measurable
all the way. Should I move these to a separate PR ?
✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
bors d+
bors r+ |
…ion (#7164) This PR introduces ways of studying and computing `∫ x, f x ∂μ` by studying the limit of the sequence `∫ x in φ n, f x ∂μ` for an appropriate sequence `φ` of subsets of the domain of `f`.
Pull request successfully merged into master. Build succeeded: |
This PR introduces ways of studying and computing
∫ x, f x ∂μ
by studying the limit of the sequence∫ x in φ n, f x ∂μ
for an appropriate sequenceφ
of subsets of the domain off
.There are a few things I'm not 100% happy with in this PR, so I'm open to suggestions. These are :
integral_eq_improper.lean
)mono_ae_cover
which isn't really clearmono_ae_cover
involves some assumptions which may be a bit too strong, but I had some troubles when trying to loosen themIxx
s, I found myself duplicating a few things between the "prove f is integrable" and "integral of f is ..." versions of the lemmas, but factoring things out involves stating a lot of lemmas which won't be useful to anything else, so I'm not sure if I should do it