[Merged by Bors] - chore(tactic/elementwise): fixes #7188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue tracking the remaining problem in #7189. |
semorrison
added
awaiting-review
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
These fixes, while an improvement, still don't fix the problem @justus-springer observed in #7092. Really we should generate a second copy of the `_apply` lemma, with the category specialized to `Type u`, and in that one remove all the coercions. Maybe later. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes, while an improvement, still don't fix the problem @justus-springer observed in #7092.
Really we should generate a second copy of the
_applylemma, with the category specialized toType u, and in that one remove all the coercions. Maybe later.