-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/special_functions/integrals): integral_comp for f : ℝ → ℝ
#7216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamindavidson
added
the
awaiting-review
The author would like community review of the PR
label
Apr 16, 2021
eric-wieser
reviewed
Apr 16, 2021
eric-wieser
added
awaiting-author
A reviewer has asked the author a question or requested changes
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 16, 2021
benjamindavidson
added
awaiting-review
The author would like community review of the PR
and removed
awaiting-author
A reviewer has asked the author a question or requested changes
labels
Apr 16, 2021
github-actions
bot
added
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Apr 17, 2021
github-actions
bot
removed
the
merge-conflict
Please `git merge origin/master` then a bot will remove this label.
label
Apr 17, 2021
eric-wieser
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks
bors r+ |
github-actions
bot
added
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 21, 2021
bors bot
pushed a commit
that referenced
this pull request
Apr 21, 2021
…→ ℝ` (#7216) In #7103 I added lemmas to deal with integrals of the form `c • ∫ x in a..b, f (c * x + d)`. However, it came to my attention that, with those lemmas, `simp` can only handle such integrals if they use `•`, not `*`. To solve this problem and enable computation of these integrals by `simp`, I add versions of the aforementioned `integral_comp` lemmas specialized with `f : ℝ → ℝ` and label them with `simp`.
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat(analysis/special_functions/integrals): integral_comp for
[Merged by Bors] - feat(analysis/special_functions/integrals): integral_comp for Apr 22, 2021
f : ℝ → ℝ
f : ℝ → ℝ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7103 I added lemmas to deal with integrals of the form
c • ∫ x in a..b, f (c * x + d)
. However, it came to my attention that, with those lemmas,simp
can only handle such integrals if they use•
, not*
. To solve this problem and enable computation of these integrals bysimp
, I add versions of the aforementionedintegral_comp
lemmas specialized withf : ℝ → ℝ
and label them withsimp
.I choose to add the new lemmas to
analysis.special_functions.integrals
and notmeasure_theory.interval_integral
because:ℝ
makes them specific enough to belong inanalysis.special_functions.integrals