Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(analysis/special_functions/integrals): integral_comp for f : ℝ → ℝ #7216

Closed
wants to merge 7 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

@benjamindavidson benjamindavidson commented Apr 16, 2021

In #7103 I added lemmas to deal with integrals of the form c • ∫ x in a..b, f (c * x + d). However, it came to my attention that, with those lemmas, simp can only handle such integrals if they use , not *. To solve this problem and enable computation of these integrals by simp, I add versions of the aforementioned integral_comp lemmas specialized with f : ℝ → ℝ and label them with simp.


I choose to add the new lemmas to analysis.special_functions.integrals and not measure_theory.interval_integral because:

  1. The fact that they are specified to makes them specific enough to belong in analysis.special_functions.integrals
  2. They are most likely to be used in conjunction with other lemmas in that file

@benjamindavidson benjamindavidson added the awaiting-review The author would like community review of the PR label Apr 16, 2021
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 16, 2021
@benjamindavidson benjamindavidson added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 16, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 17, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 17, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks

@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 21, 2021
bors bot pushed a commit that referenced this pull request Apr 21, 2021
…→ ℝ` (#7216)

In #7103 I added lemmas to deal with integrals of the form `c • ∫ x in a..b, f (c * x + d)`. However, it came to my attention that, with those lemmas, `simp` can only handle such integrals if they use `•`, not `*`. To solve this problem and enable computation of these integrals by `simp`, I add versions of the aforementioned `integral_comp` lemmas specialized with `f : ℝ → ℝ` and label them with `simp`.
@bors
Copy link

bors bot commented Apr 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/special_functions/integrals): integral_comp for f : ℝ → ℝ [Merged by Bors] - feat(analysis/special_functions/integrals): integral_comp for f : ℝ → ℝ Apr 22, 2021
@bors bors bot closed this Apr 22, 2021
@bors bors bot deleted the real_comp branch April 22, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants