[Merged by Bors] - chore(algebra): add sub{_mul_action,module,semiring,ring,field,algebra}.copy
#7220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…}.copy
We already have this for sub{monoid,group}. With this in place, we can make `coe subalgebra.range` defeq to `set.range` and similar.
eric-wieser
changed the title
sub{algebra,module,mul_action,ring,semiring,field}.copysub{_mul_action,module,semiring,ring,field,algebra}.copy
eric-wieser
commented
Apr 16, 2021
eric-wieser
added
the
awaiting-review
Vierkantor
approved these changes
Apr 16, 2021
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
Vierkantor
added
awaiting-author
|
I don't think those lemmas are that useful - all the places we use Generalizing to set_like would require generalizing over hom types, which I don't think is something we're ready for yet. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
…ra}.copy` (#7220) We already have this for sub{monoid,group}. With this in place, we can make `coe subalgebra.range` defeq to `set.range` and similar (left for a follow-up).
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
sub{_mul_action,module,semiring,ring,field,algebra}.copysub{_mul_action,module,semiring,ring,field,algebra}.copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have this for sub{monoid,group}. With this in place, we can make
coe subalgebra.rangedefeq toset.rangeand similar (left for a follow-up).