Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fintype): add @[simp] to card_univ #7230

Closed
wants to merge 1 commit into from
Closed

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Apr 17, 2021


Open in Gitpod

This feels like a simp lemma, which makes me fear that there's a good reason that it's not done yet. Please don't merge instantly - if compile doesn't scream at me (and others agree it seems like a good idea) I'll just make one more pass removing any explicit card_univs from other files

@ericrbg ericrbg added RFC Request for comment easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 17, 2021
@bryangingechen
Copy link
Collaborator

It's not obvious to me that this should be a simp lemma in this direction; isn't fintype.card defined in terms of finset.univ.card? (It could potentially be a good idea, if fintype.card has a more extensive API, but that seems unlikely to me.)

Regarding the PR title, I think we usually use "feat" for new theorems (stuff with at least some recognizable "mathematical" content) or tactics; in my opinion, adding attributes & other general code cleanup falls under "refactor", "fix" or "chore".

@ericrbg
Copy link
Collaborator Author

ericrbg commented Apr 17, 2021

yes, fintype.card is finset.univ.card; however, fintype has results such as |α → β| = |β| ^ |α|, |α ⊕ β| = |α| + |β|, whilst it seems to me that most finset results about card are about subsets, insertions, maps and such like; however, not sure if this is just me as I'm working with a fair few pigeonhole/cardinality arguments right now.

@ericrbg
Copy link
Collaborator Author

ericrbg commented Apr 17, 2021

I'll fix the title! I wasn't sure about what to title it when I first added it

@ericrbg ericrbg changed the title feat(fintype): add @[simp] to card_univ chore(fintype): add @[simp] to card_univ Apr 17, 2021
@ericrbg
Copy link
Collaborator Author

ericrbg commented Apr 25, 2021

close as not a good idea

@ericrbg ericrbg closed this Apr 25, 2021
@ericrbg ericrbg removed RFC Request for comment easy < 20s of review time. See the lifecycle page for guidelines. not-ready-to-merge labels Apr 25, 2021
@ericrbg ericrbg deleted the ericrbg-patch-1 branch April 25, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants