Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/continuous_function): lemmas about pointwise sup/inf #7249

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(topology/continuous_function): lemmas about pointwise sup/inf #7249

wants to merge 6 commits into from

Conversation

semorrison
Copy link
Collaborator

Prerequisites PR for Stone-Weierstrass

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Apr 18, 2021
gebner
gebner reviewed Apr 19, 2021
View reviewed changes
src/topology/continuous_function/basic.lean Outdated Show resolved Hide resolved
src/topology/continuous_function/basic.lean Outdated Show resolved Hide resolved
src/topology/continuous_function/basic.lean Outdated Show resolved Hide resolved
src/topology/continuous_function/basic.lean Outdated Show resolved Hide resolved
@gebner gebner added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 19, 2021
@semorrison @gebner @eric-wieser
Apply suggestions from code review
5e8deac 
Co-authored-by: Gabriel Ebner <gebner@gebner.org>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 20, 2021
@eric-wieser eric-wieser mentioned this pull request Apr 20, 2021
Closed
@sgouezel
Copy link
Collaborator

Can you merge master once #7275 is merged, and set it back to awaiting_review then?

@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 21, 2021
@eric-wieser
Copy link
Member

It's now merged

@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 22, 2021
eric-wieser
eric-wieser approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@eric-wieser
Copy link
Member

bors r-

@bors
Copy link

bors bot commented Apr 22, 2021

Canceled.

@eric-wieser
Copy link
Member

Oh, the linter fails

@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Apr 22, 2021
@semorrison
feat(topology/continuous_function): lemmas about pointwise sup/inf (#…
96d5730 
…7249)




Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Apr 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/continuous_function): lemmas about pointwise sup/inf [Merged by Bors] - feat(topology/continuous_function): lemmas about pointwise sup/inf Apr 22, 2021
@bors bors bot closed this Apr 22, 2021
@bors bors bot deleted the cf_sup branch April 22, 2021 14:56
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @sgouezel @eric-wieser @gebner @YaelDillies