Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order): add some missing pi and Prop instances #7268

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(order): add some missing pi and Prop instances #7268

wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Apr 19, 2021

Open in Gitpod

@urkud urkud added the awaiting-review The author would like community review of the PR label Apr 19, 2021
eric-wieser
eric-wieser reviewed Apr 23, 2021
View reviewed changes
src/order/complete_lattice.lean
@@ -926,6 +926,10 @@ lemma supr_subtype' {p : ι → Prop} {f : ∀ i, p i → α} :
(⨆ i (h : p i), f i h) = (⨆ x : subtype p, f x x.property) :=
(@supr_subtype _ _ _ p (λ x, f x.val x.property)).symm

lemma supr_subtype'' {ι} (s : set ι) (f : ι → α) :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps

Suggested change
lemma supr_subtype'' {ι} (s : set ι) (f : ι → α) :
lemma supr_coe_subtype {ι} (s : set ι) (f : ι → α) :

or

Suggested change
lemma supr_subtype'' {ι} (s : set ι) (f : ι → α) :
lemma supr_subtype_coe {ι} (s : set ι) (f : ι → α) :

since (⨆ i : s, f i) is coercing i?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to separate feature PRs from refactor PRs. Probably we need a PR that uniformizes lemma names for these lemmas and similar lemmas about forall/exists/Union/Inter.

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed awaiting-review The author would like community review of the PR labels Apr 25, 2021
@bryangingechen
Copy link
Collaborator

merge conflict
bors r-
bors d+

@bors
Copy link

bors bot commented Apr 25, 2021

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bors
Copy link

bors bot commented Apr 25, 2021

Canceled.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Apr 25, 2021
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions. and removed delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Apr 25, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 3, 2021
@urkud
Copy link
Member Author

urkud commented May 4, 2021

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 4, 2021
bors bot pushed a commit that referenced this pull request May 4, 2021
@urkud
feat(order): add some missing pi and Prop instances (#7268)
612874f
@bors
Copy link

bors bot commented May 4, 2021

Timed out.

@bryangingechen
Copy link
Collaborator

bors r+

bors bot pushed a commit that referenced this pull request May 4, 2021
@urkud
feat(order): add some missing pi and Prop instances (#7268)
37894e0
@bors
Copy link

bors bot commented May 4, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 4, 2021
@urkud
feat(order): add some missing pi and Prop instances (#7268)
b177a3b
@bors
Copy link

bors bot commented May 4, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 5, 2021
@urkud
feat(order): add some missing pi and Prop instances (#7268)
1ca0fd4
@bors
Copy link

bors bot commented May 5, 2021

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 5, 2021
@urkud
feat(order): add some missing pi and Prop instances (#7268)
93bc7e0
@bors
Copy link

bors bot commented May 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order): add some missing pi and Prop instances [Merged by Bors] - feat(order): add some missing pi and Prop instances May 5, 2021
@bors bors bot closed this May 5, 2021
@bors bors bot deleted the pi-inst branch May 5, 2021 23:47
Vierkantor pushed a commit that referenced this pull request May 6, 2021
@urkud @Vierkantor
feat(order): add some missing pi and Prop instances (#7268)
84438ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @semorrison @bryangingechen @eric-wieser