Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/finset/basic): list.to_finset on list ops #7297

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/finset/basic): list.to_finset on list ops #7297

wants to merge 2 commits into from

Conversation

pechersky
Copy link
Collaborator

Open in Gitpod

@pechersky pechersky mentioned this pull request Apr 21, 2021
Closed
7 tasks
@pechersky pechersky added the awaiting-author A reviewer has asked the author a question or requested changes label Apr 21, 2021
@pechersky pechersky added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 21, 2021
Vierkantor
Vierkantor approved these changes Apr 21, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me otherwise, thanks!

bors d+

@bors
Copy link

bors bot commented Apr 21, 2021

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@Vierkantor Vierkantor added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Apr 21, 2021
@pechersky
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Apr 22, 2021
@pechersky
feat(data/finset/basic): list.to_finset on list ops (#7297)
b3b74f8
@bors
Copy link

bors bot commented Apr 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finset/basic): list.to_finset on list ops [Merged by Bors] - feat(data/finset/basic): list.to_finset on list ops Apr 22, 2021
@bors bors bot closed this Apr 22, 2021
@bors bors bot deleted the pechersky/to-finset-list-ops branch April 22, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pechersky @Vierkantor